From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3456B2B9E for ; Wed, 24 Feb 2016 09:27:26 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 24 Feb 2016 00:27:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,493,1449561600"; d="scan'208";a="910074990" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by fmsmga001.fm.intel.com with ESMTP; 24 Feb 2016 00:27:23 -0800 Date: Wed, 24 Feb 2016 16:28:55 +0800 From: Yuanhan Liu To: "Qiu, Michael" Message-ID: <20160224082855.GE14300@yliu-dev.sh.intel.com> References: <20160219070326.GR21426@yliu-dev.sh.intel.com> <1456151771-15382-1-git-send-email-yuanhan.liu@linux.intel.com> <533710CFB86FA344BFBF2D6802E6028622F54AB4@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F54AB4@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" , Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH] vhost: broadcast RARP pkt by injecting it to receiving mbuf array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 08:27:26 -0000 On Wed, Feb 24, 2016 at 08:15:36AM +0000, Qiu, Michael wrote: > On 2/22/2016 10:35 PM, Yuanhan Liu wrote: > > Broadcast RARP packet by injecting it to receiving mbuf array at > > rte_vhost_dequeue_burst(). > > > > Commit 33226236a35e ("vhost: handle request to send RARP") iterates > > all host interfaces and then broadcast it by all of them. It did > > notify the switches about the new location of the migrated VM, however, > > the mac learning table in the target host is wrong (at least in my > > test with OVS): > > > > $ ovs-appctl fdb/show ovsbr0 > > port VLAN MAC Age > > 1 0 b6:3c:72:71:cd:4d 10 > > LOCAL 0 b6:3c:72:71:cd:4e 10 > > LOCAL 0 52:54:00:12:34:68 9 > > 1 0 56:f6:64:2c:bc:c0 1 > > > > Where 52:54:00:12:34:68 is the mac of the VM. As you can see from the > > above, the port learned is "LOCAL", which is the "ovsbr0" port. That > > is reasonable, since we indeed send the pkt by the "ovsbr0" interface. > > > > The wrong mac table lead all the packets to the VM go to the "ovsbr0" > > in the end, which ends up with all packets being lost, until the guest > > send a ARP quest (or reply) to refresh the mac learning table. > > > > Jianfeng then came up with a solution I have thought of firstly but NAKed > > Is it suitable to mention someone in the commit log? Why it's not? It's not a secret name or something like that after all :) On the other hand, it's way of thanking Jianfeng's contribution to this patch. --yliu