From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A8AC52B94 for ; Wed, 24 Feb 2016 11:10:15 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 24 Feb 2016 02:10:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,493,1449561600"; d="scan'208";a="752292695" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64]) by orsmga003.jf.intel.com with SMTP; 24 Feb 2016 02:10:13 -0800 Received: by (sSMTP sendmail emulation); Wed, 24 Feb 2016 10:10:11 +0025 Date: Wed, 24 Feb 2016 10:10:11 +0000 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20160224101011.GA19784@bricha3-MOBL3> References: <91026831.UvMIbM9v17@xps13> <2221343.vDGpEpgp97@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2221343.vDGpEpgp97@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, "Kantecki, Tomasz" Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 10:10:16 -0000 On Wed, Feb 24, 2016 at 09:24:33AM +0100, Thomas Monjalon wrote: > 2016-02-23 23:03, Kantecki, Tomasz: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > If there is nothing specific in DPDK for PQos, why writing an example in > > > DPDK? > > The example makes it much easier to use the technology with DPDK. > > > > > Maybe the example should be better in the library itself. > > The library in question (https://github.com/01org/intel-cmt-cat) has a couple of examples but none of them refers to DPDK. > > > > > I suggest to mention the library in > > > doc/guides/linux_gsg/nic_perf_intel_platform.rst > > Ok it can be added to this document. Does it imply -1 for the sample code idea? > > I may be wrong but I have the feeling the example is more about PQoS than DPDK. > So yes, I would vote -1. > Well, the intersection of DPDK and PQoS is what the example is really all about, and as such it is relevant to both DPDK and the library itself. Platform QoS can be of great use to packet processing applications for helping to ensure that the app gets the resources it needed - especially in a virtualised world - and so we believe that having an example in DPDK showing how to use PQoS with DPDK is well worthwhile having. It's more effective than a simple doc update in raising awareness of the existence of the feature, and also provides for DPDK users a readily available app for the user to start playing with to evaluate PQoS for their own use-cases. I also fail to see what the downside of having the sample app is - it won't add significantly to the project maintenance overhead. Regards, /Bruce