From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0FE6828BF for ; Wed, 24 Feb 2016 17:24:23 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 24 Feb 2016 08:24:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,494,1449561600"; d="scan'208";a="53937391" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64]) by fmsmga004.fm.intel.com with SMTP; 24 Feb 2016 06:08:32 -0800 Received: by (sSMTP sendmail emulation); Wed, 24 Feb 2016 14:08:32 +0025 Date: Wed, 24 Feb 2016 14:08:32 +0000 From: Bruce Richardson To: Rahul Lakkireddy Message-ID: <20160224140832.GB19616@bricha3-MOBL3> References: <52cbd2698f43bf5753fbb9b7e9d1dd678519d61f.1454152758.git.rahul.lakkireddy@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52cbd2698f43bf5753fbb9b7e9d1dd678519d61f.1454152758.git.rahul.lakkireddy@chelsio.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, Felix Marti , Nirranjan Kirubaharan , Kumar Sanghvi Subject: Re: [dpdk-dev] [PATCH 1/2] cxgbe: fix to copy pci info to other ports under same PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 16:24:24 -0000 On Sun, Jan 31, 2016 at 04:52:49PM +0530, Rahul Lakkireddy wrote: > Chelsio NIC ports share a single PF. Move rte_eth_copy_pci_info() > to copy the pci device information to the remaining ports as well. > > Fixes: eeefe73f0af1 ("drivers: copy PCI device info to ethdev data") > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Kumar Sanghvi > --- Hi, can you perhaps submit this fix as a patch alone, without the copyright update patch attached. [Feel free to upate the copyright year on the two files affected here by this change, if you like.] FYI: Also, the commit title is slightly too long. It should be around 50 characters long (for me, vim highlights the correct length for me). It could be shortened by dropping the word "other". :-) /Bruce > drivers/net/cxgbe/cxgbe_ethdev.c | 2 -- > drivers/net/cxgbe/cxgbe_main.c | 3 +++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c > index 97ef152..fd0eb1c 100644 > --- a/drivers/net/cxgbe/cxgbe_ethdev.c > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c > @@ -819,8 +819,6 @@ static int eth_cxgbe_dev_init(struct rte_eth_dev *eth_dev) > > pci_dev = eth_dev->pci_dev; > > - rte_eth_copy_pci_info(eth_dev, pci_dev); > - > snprintf(name, sizeof(name), "cxgbeadapter%d", eth_dev->data->port_id); > adapter = rte_zmalloc(name, sizeof(*adapter), 0); > if (!adapter) > diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c > index aff23d0..6c7eb7f 100644 > --- a/drivers/net/cxgbe/cxgbe_main.c > +++ b/drivers/net/cxgbe/cxgbe_main.c > @@ -1166,6 +1166,9 @@ allocate_mac: > pi->eth_dev->dev_ops = adapter->eth_dev->dev_ops; > pi->eth_dev->tx_pkt_burst = adapter->eth_dev->tx_pkt_burst; > pi->eth_dev->rx_pkt_burst = adapter->eth_dev->rx_pkt_burst; > + > + rte_eth_copy_pci_info(pi->eth_dev, pi->eth_dev->pci_dev); > + > TAILQ_INIT(&pi->eth_dev->link_intr_cbs); > > pi->eth_dev->data->mac_addrs = rte_zmalloc(name, > -- > 2.5.3 >