From: Bruce Richardson <bruce.richardson@intel.com>
To: "He, Shaopeng" <shaopeng.he@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x
Date: Wed, 24 Feb 2016 14:26:06 +0000 [thread overview]
Message-ID: <20160224142606.GC19616@bricha3-MOBL3> (raw)
In-Reply-To: <FB82FCC69332B84596FE0CEC3C131094BFCAD0@shsmsx102.ccr.corp.intel.com>
On Thu, Feb 04, 2016 at 06:21:04AM +0000, He, Shaopeng wrote:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Monday, February 01, 2016 4:43 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x
> >
> > Normally the auto-negotiation is supported by FW. But on
> > X550EM_X_10G_T it's not supported by FW. As the port of
> > X550EM_X_10G_T is 10G. If we connect the port with a peer
> > which is 1G. The link is always down.
> > We have to supprted auto-neg by SW to avoid such link down
> > issue.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Shaopeng He <shaopeng.he@intel.com>
>
I'm a bit confused regarding the commit message and the code in the patch.
The commit message talks about enabling speed auto-negotiation, while the code
never refers to any such thing. Instead all we have are settings for manipulating
interrupt masks to enable PHY interrupts. I think some additional information is
needed to connect A and B together here.
A second, more minor nit is that the commit title never refers to link
auto-negotiation, but refers to this as a bug fix - which is also correct. If
this is primarily a bug fix, please include a fixes line if possible, but please
also refer to auto-neg in the title if possible too.
/Bruce
next prev parent reply other threads:[~2016-02-24 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 7:56 [dpdk-dev] [PATCH] " Wenzhuo Lu
2016-02-01 8:22 ` He, Shaopeng
2016-02-01 8:26 ` Lu, Wenzhuo
2016-02-01 8:42 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2016-02-04 6:21 ` He, Shaopeng
2016-02-24 14:26 ` Bruce Richardson [this message]
2016-02-25 1:32 ` Lu, Wenzhuo
2016-02-25 13:29 ` Bruce Richardson
2016-02-26 0:46 ` Lu, Wenzhuo
2016-02-24 14:26 ` Bruce Richardson
2016-02-25 1:35 ` Lu, Wenzhuo
2016-02-26 3:05 ` [dpdk-dev] [PATCH v3] ixgbe: support link speed auto-neg " Wenzhuo Lu
2016-03-08 17:34 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224142606.GC19616@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shaopeng.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).