From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 235282BBB for ; Wed, 24 Feb 2016 15:26:17 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 24 Feb 2016 06:26:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,494,1449561600"; d="scan'208";a="893669878" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64]) by orsmga001.jf.intel.com with SMTP; 24 Feb 2016 06:26:10 -0800 Received: by (sSMTP sendmail emulation); Wed, 24 Feb 2016 14:26:06 +0025 Date: Wed, 24 Feb 2016 14:26:06 +0000 From: Bruce Richardson To: "He, Shaopeng" Message-ID: <20160224142606.GC19616@bricha3-MOBL3> References: <1450684592-13564-1-git-send-email-wenzhuo.lu@intel.com> <1454316159-9528-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 14:26:18 -0000 On Thu, Feb 04, 2016 at 06:21:04AM +0000, He, Shaopeng wrote: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Monday, February 01, 2016 4:43 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x > > > > Normally the auto-negotiation is supported by FW. But on > > X550EM_X_10G_T it's not supported by FW. As the port of > > X550EM_X_10G_T is 10G. If we connect the port with a peer > > which is 1G. The link is always down. > > We have to supprted auto-neg by SW to avoid such link down > > issue. > > > > Signed-off-by: Wenzhuo Lu > Acked-by: Shaopeng He > I'm a bit confused regarding the commit message and the code in the patch. The commit message talks about enabling speed auto-negotiation, while the code never refers to any such thing. Instead all we have are settings for manipulating interrupt masks to enable PHY interrupts. I think some additional information is needed to connect A and B together here. A second, more minor nit is that the commit title never refers to link auto-negotiation, but refers to this as a bug fix - which is also correct. If this is primarily a bug fix, please include a fixes line if possible, but please also refer to auto-neg in the title if possible too. /Bruce