From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 324622BBB
 for <dev@dpdk.org>; Wed, 24 Feb 2016 15:26:59 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 24 Feb 2016 06:26:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,494,1449561600"; d="scan'208";a="893670315"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64])
 by orsmga001.jf.intel.com with SMTP; 24 Feb 2016 06:26:53 -0800
Received: by  (sSMTP sendmail emulation); Wed, 24 Feb 2016 14:26:52 +0025
Date: Wed, 24 Feb 2016 14:26:52 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Message-ID: <20160224142652.GD19616@bricha3-MOBL3>
References: <1450684592-13564-1-git-send-email-wenzhuo.lu@intel.com>
 <1454316159-9528-1-git-send-email-wenzhuo.lu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454316159-9528-1-git-send-email-wenzhuo.lu@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2016 14:26:59 -0000

On Mon, Feb 01, 2016 at 04:42:39PM +0800, Wenzhuo Lu wrote:
> Normally the auto-negotiation is supported by FW. But on
> X550EM_X_10G_T it's not supported by FW. As the port of
> X550EM_X_10G_T is 10G. If we connect the port with a peer
> which is 1G. The link is always down.
> We have to supprted auto-neg by SW to avoid such link down
> issue.
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
>  doc/guides/rel_notes/release_2_3.rst |  6 ++++++
>  drivers/net/ixgbe/ixgbe_ethdev.c     | 38 ++++++++++++++++++++++++++++++++++++
>  drivers/net/ixgbe/ixgbe_ethdev.h     |  1 +
>  3 files changed, 45 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst
> index 99de186..a8d34d1 100644
> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -15,6 +15,12 @@ EAL
>  Drivers
>  ~~~~~~~
>  
> +* **ixgbe: fix link down issue on X550EM_X.**
> +  Normally the auto-negotiation is supported by FW. SW need not care about
> +  that. But on x550em_x, FW doesn't support auto-neg. As the ports of x550em_x
> +  are 10G, if we connect the port will a peer which is 1G, the link will always
> +  be donw on x550em_x.
> +  We will support auto-neg by SW to avoid this link down issue.
>  

Couple of typos present in the text above.

/Bruce