From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E186629D2 for ; Thu, 25 Feb 2016 14:29:50 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 25 Feb 2016 05:29:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="923714344" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64]) by fmsmga002.fm.intel.com with SMTP; 25 Feb 2016 05:29:47 -0800 Received: by (sSMTP sendmail emulation); Thu, 25 Feb 2016 13:29:47 +0025 Date: Thu, 25 Feb 2016 13:29:47 +0000 From: Bruce Richardson To: "Lu, Wenzhuo" Message-ID: <20160225132946.GA20868@bricha3-MOBL3> References: <1450684592-13564-1-git-send-email-wenzhuo.lu@intel.com> <1454316159-9528-1-git-send-email-wenzhuo.lu@intel.com> <20160224142606.GC19616@bricha3-MOBL3> <6A0DE07E22DDAD4C9103DF62FEBC09090343540D@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090343540D@shsmsx102.ccr.corp.intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2016 13:29:51 -0000 On Thu, Feb 25, 2016 at 01:32:33AM +0000, Lu, Wenzhuo wrote: > Hi Bruce, > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Wednesday, February 24, 2016 10:26 PM > > To: He, Shaopeng > > Cc: Lu, Wenzhuo; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on x550em_x > > > > On Thu, Feb 04, 2016 at 06:21:04AM +0000, He, Shaopeng wrote: > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > > Sent: Monday, February 01, 2016 4:43 PM > > > > To: dev@dpdk.org > > > > Subject: [dpdk-dev] [PATCH v2] ixgbe: fix link down issue on > > > > x550em_x > > > > > > > > Normally the auto-negotiation is supported by FW. But on > > > > X550EM_X_10G_T it's not supported by FW. As the port of > > > > X550EM_X_10G_T is 10G. If we connect the port with a peer which is > > > > 1G. The link is always down. > > > > We have to supprted auto-neg by SW to avoid such link down issue. > > > > > > > > Signed-off-by: Wenzhuo Lu > > > Acked-by: Shaopeng He > > > > > I'm a bit confused regarding the commit message and the code in the patch. > > The commit message talks about enabling speed auto-negotiation, while the > > code never refers to any such thing. Instead all we have are settings for > > manipulating interrupt masks to enable PHY interrupts. I think some additional > > information is needed to connect A and B together here. > The reason is that the handler of the link speed auto-neg is already in the base code. It's ixgbe_handle_lasi. > What we need is a trigger. When the advertised link speed changes, a PHY interruption will be triggered. So, we should handle this interruption and call ixgbe_handle_lasi to set the link speed correct. > Let me add more explanation in the commit log. > Yes, please do. What you have just explained makes much more sense and should be included in the log. > > > > A second, more minor nit is that the commit title never refers to link auto- > > negotiation, but refers to this as a bug fix - which is also correct. If this is > > primarily a bug fix, please include a fixes line if possible, but please also refer to > > auto-neg in the title if possible too. > I didn't add a fixes line because it doesn't fix an issue introduced by SW, or even FW, HW. As said in commit log, we hit a link down issue, but the root cause is the link speed auto-neg is not supported on this specific NIC. > On the other NICs, link speed auto-neg is supported by FW, SW need no do anything. So we didn't implement the link speed auto-neg. But we have to implement this feature on this NIC for FW doesn't implement it. > Should I change the tittle to "support link speed auto-neg on x550em_x"? > Yes, that is probably better. Thanks, /Bruce