From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 14C9F2C23 for ; Fri, 26 Feb 2016 09:26:38 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id b205so62424122wmb.1 for ; Fri, 26 Feb 2016 00:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ac1KipcD3ZJ+iNRM3UEOeJgGiFW1Rt1bUL+pmoUgiH0=; b=SHb++f8oJh2Lnvl96/DVb62jSAetPsV0vO/bPqugBCbzl6jk3xRTsUQSfuRf5BJldb kcUFkUXjIYpw432pPd2RuVCnyjmCnuwQOA+7F3TisqwmUiDT3BtWwJbLGLEzup75luA4 Ln+8StBQTn9FORRr3L3DBuPZdnFVp46e8mpH5eXg5fA3h857Dvgv+KCfa14HrUT4B4AG N3NS2QbQMSZeG7jFAXRtJJZZuAtgYs5EBjSmOlaoDVBx6wr9HEmAiszJHJY43opUu3I8 G3ABbhI6WrSq5f3E29lJRBAzjwxsnwcgBmxi/mSVtwK+hf0CjcyapbPo4NApLeyxIqVK GOOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ac1KipcD3ZJ+iNRM3UEOeJgGiFW1Rt1bUL+pmoUgiH0=; b=Ud0e174Y8uW1ShX2AKy6zTawagAjFJbqFn+TC6QP79/x7ctdzz8P90kXH/036d/X5G Hw0yxryFAO8/bHsB+aJFZm3FCn/+jvV2TRLOE66HpN4pzVZKB6T+fFGyY22aX7eNULTz obFgTea3AO/LJDXDQwYD7ZlXwM4mnkLJWXJjqLWQJTIjMoDrerSt2oPYbpS98wciN87f w64UT5W+OjwNlNCflWRE7fO6j4uTQBHSesY4VcvsQ8ECAdh8RU1PV4pxCA+IhcGdMqR6 reQjPAnb/aF+CWI70gLMDtIRvV7jxA/4ZvlcIkOnksrIX8KWqKw5JSQyMGOeIyfKkMrC ReRA== X-Gm-Message-State: AD7BkJJEAjxfL4L3IykX8p1B/lB7bCou44QftV7KV3xjyMWsnGe6SxLLL+CYE5fsvIOJo/tK X-Received: by 10.194.84.66 with SMTP id w2mr376056wjy.6.1456475197965; Fri, 26 Feb 2016 00:26:37 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id o128sm1798100wmb.19.2016.02.26.00.26.36 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Feb 2016 00:26:37 -0800 (PST) Date: Fri, 26 Feb 2016 09:26:22 +0100 From: Adrien Mazarguil To: Jianfeng Tan Message-ID: <20160226082622.GB27079@6wind.com> Mail-Followup-To: Jianfeng Tan , dev@dpdk.org, helin.zhang@intel.com, konstantin.ananyev@intel.com, nelio.laranjeiro@6wind.com, rahul.lakkireddy@chelsio.com References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1456445371-147264-1-git-send-email-jianfeng.tan@intel.com> <1456445371-147264-10-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456445371-147264-10-git-send-email-jianfeng.tan@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 09/12] pmd/mlx5: add dev_ptype_info_get implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 08:26:38 -0000 Hi Jianfeng, On Fri, Feb 26, 2016 at 08:09:28AM +0800, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan > --- > drivers/net/mlx4/mlx4.c | 2 +- > drivers/net/mlx5/mlx5.c | 1 + > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_ethdev.c | 20 ++++++++++++++++++++ > drivers/net/mlx5/mlx5_rxtx.c | 2 ++ > 5 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index 85fdebf..58f4e1a 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -4269,7 +4269,7 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > priv_unlock(priv); > } > > -static uint32_t * > +static const uint32_t * > mlx4_dev_ptype_info_get(struct rte_eth_dev *dev) > { > static const uint32_t ptypes[] = { I'm probably nitpicking here but this change should be merged in the mlx4 patch. Otherwise both mlx4 and mlx5 patches look fine to me. -- Adrien Mazarguil 6WIND