From: Bruce Richardson <bruce.richardson@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice
Date: Fri, 26 Feb 2016 14:39:11 +0000 [thread overview]
Message-ID: <20160226143911.GA21628@bricha3-MOBL3> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9AE93C@SHSMSX104.ccr.corp.intel.com>
On Tue, Feb 23, 2016 at 02:10:57AM +0000, Zhang, Helin wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> > Sent: Friday, January 29, 2016 1:58 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice
> >
> > Currently, ixgbe vf and pf will disable interrupt twice in stop stage and uninit
> > stage. It will cause an error:
> >
> > testpmd> quit
> >
> > Shutting down port 0...
> > Stopping ports...
> > Done
> > Closing ports...
> > EAL: Error disabling MSI-X interrupts for fd 26
> > Done
> >
> > Becasue the interrupt already been disabled in stop stage.
> > Since it is enabled in init stage, better remove from stop stage.
> >
> > Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF")
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
>
applied to dpdk-next-net/rel_16_04
/Bruce
prev parent reply other threads:[~2016-02-26 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 5:51 [dpdk-dev] [PATCH] " Michael Qiu
2016-01-29 5:58 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2016-01-29 8:07 ` Lu, Wenzhuo
2016-02-01 8:05 ` Qiu, Michael
2016-02-02 1:03 ` Lu, Wenzhuo
2016-02-02 2:06 ` Qiu, Michael
2016-02-02 2:14 ` Zhang, Helin
2016-02-02 2:57 ` Qiu, Michael
2016-02-02 3:07 ` Zhang, Helin
2016-02-02 3:15 ` Qiu, Michael
2016-02-02 11:03 ` Ananyev, Konstantin
2016-02-19 8:07 ` Qiu, Michael
2016-02-19 15:14 ` Ananyev, Konstantin
2016-02-02 2:26 ` Lu, Wenzhuo
2016-02-23 2:10 ` Zhang, Helin
2016-02-26 14:39 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226143911.GA21628@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).