From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 984D94CE4
 for <dev@dpdk.org>; Fri, 26 Feb 2016 15:39:15 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 26 Feb 2016 06:39:14 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="921763153"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63])
 by orsmga002.jf.intel.com with SMTP; 26 Feb 2016 06:39:12 -0800
Received: by  (sSMTP sendmail emulation); Fri, 26 Feb 2016 14:39:12 +0025
Date: Fri, 26 Feb 2016 14:39:11 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Message-ID: <20160226143911.GA21628@bricha3-MOBL3>
References: <1454046700-20843-1-git-send-email-michael.qiu@intel.com>
 <1454047090-21274-1-git-send-email-michael.qiu@intel.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9AE93C@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A9AE93C@SHSMSX104.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Feb 2016 14:39:16 -0000

On Tue, Feb 23, 2016 at 02:10:57AM +0000, Zhang, Helin wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
> > Sent: Friday, January 29, 2016 1:58 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] ixgbe: Fix disable interrupt twice
> > 
> > Currently, ixgbe vf and pf will disable interrupt twice in stop stage and uninit
> > stage. It will cause an error:
> > 
> >     testpmd> quit
> > 
> >     Shutting down port 0...
> >     Stopping ports...
> >     Done
> >     Closing ports...
> >     EAL: Error disabling MSI-X interrupts for fd 26
> >     Done
> > 
> > Becasue the interrupt already been disabled in stop stage.
> > Since it is enabled in init stage, better remove from stop stage.
> > 
> > Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF")
> > 
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
> 
applied to dpdk-next-net/rel_16_04

/Bruce