From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
by dpdk.org (Postfix) with ESMTP id 70F9556B7
for <dev@dpdk.org>; Fri, 26 Feb 2016 16:17:07 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id a4so74079846wme.1
for <dev@dpdk.org>; Fri, 26 Feb 2016 07:17:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=71tM6HUpromz1YkN9ZG7KzrQM8HE+lQitq7tzjVxS88=;
b=l0+9KPL/lH7vp12k8yP7IakniSSrM2gEupxCDIRNwcUYCRFhpAlnyC6Rx82HLsUfTb
ENW80n2XvhnWzfhpJ09U2XiqiUrmIMY+mBoMX0BtGqFj5whWnYpPbrAVvjd7sKUQl+hx
IOVaLvZ2/r7G/TLn5Di8aBSi+LRcE3KnZog2kZVK7Szow616up2s/BDY0ewrse00fOY/
PpfCpqa1II8SYODy+QM7Z/GkVs62T2Ye0gh4ozIQ69rIZWAtIxUhQ/pKJbDy5zvnOozv
QHjzPqvfI18pH/T5jmoUK3gQXGQQXPuUQ4a1VMW5y1CdcNqn0bRcl97Sprw2bArg7J8f
KMxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=71tM6HUpromz1YkN9ZG7KzrQM8HE+lQitq7tzjVxS88=;
b=ZSNU18C0V98mqY5pHyRJFAVNRnNstNy/tEGjHaSQdE6/2ZioZFNcJzsVjQvV7GWMGA
t2J7hslwPGX6xiZQNl5iF0DGsgzMM7HbTC8nOOVPqnQLSgWw0GJuAt4hnIJ5LmBSaZDO
+xl3sQORSuv0S1+8Q2+PrpJyNoUEwoWW6+zX6BlfcmtKqufZ73HcHsaXgkgW5EFhhSbg
oVT4ZScs2oYaVDv7MgzJK9/kGpR//R4/3PyUE7PsjX/SXiH8lCwLo72mC2fsyugj34jh
7NtN/zmolOBEsrDmdyNbm6BygT23hmUR0S2blbnFd67Hf4+9aZ/C53dtvVXsehN3yZNk
hOAw==
X-Gm-Message-State: AD7BkJLVfsFv+GwuTK5cFZZCeavsrcXFZkH0AzwHBLNWpRYxalSyCQG6JWfbyjZo/LxIUkWz
X-Received: by 10.28.88.15 with SMTP id m15mr3620310wmb.60.1456499827255;
Fri, 26 Feb 2016 07:17:07 -0800 (PST)
Received: from autoinstall.dev.6wind.com
(guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177])
by smtp.gmail.com with ESMTPSA id j18sm3315559wmd.2.2016.02.26.07.17.05
(version=TLSv1/SSLv3 cipher=OTHER);
Fri, 26 Feb 2016 07:17:06 -0800 (PST)
Date: Fri, 26 Feb 2016 16:16:51 +0100
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: john.mcnamara@intel.com
Message-ID: <20160226151651.GE2105@autoinstall.dev.6wind.com>
References: <1452090774-10650-1-git-send-email-nelio.laranjeiro@6wind.com>
<1452595749-11297-1-git-send-email-nelio.laranjeiro@6wind.com>
<1452595749-11297-2-git-send-email-nelio.laranjeiro@6wind.com>
<5694F58F.1040105@redhat.com>
<20160115084439.GW13678@autoinstall.dev.6wind.com>
<5698B51B.60603@redhat.com> <569CF8F3.2020908@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <569CF8F3.2020908@6wind.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] cmdline: increase command line buffer
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Feb 2016 15:17:07 -0000
On Mon, Jan 18, 2016 at 03:38:43PM +0100, Olivier MATZ wrote:
> Hi,
>
> On 01/15/2016 10:00 AM, Panu Matilainen wrote:
> >>>> diff --git a/lib/librte_cmdline/cmdline_rdline.h
> >>>> b/lib/librte_cmdline/cmdline_rdline.h
> >>>> index b9aad9b..72e2dad 100644
> >>>> --- a/lib/librte_cmdline/cmdline_rdline.h
> >>>> +++ b/lib/librte_cmdline/cmdline_rdline.h
> >>>> @@ -93,7 +93,7 @@ extern "C" {
> >>>> #endif
> >>>>
> >>>> /* configuration */
> >>>> -#define RDLINE_BUF_SIZE 256
> >>>> +#define RDLINE_BUF_SIZE 512
> >>>> #define RDLINE_PROMPT_SIZE 32
> >>>> #define RDLINE_VT100_BUF_SIZE 8
> >>>> #define RDLINE_HISTORY_BUF_SIZE BUFSIZ
> >>>
> >>> Having to break a library ABI for a change like this is a bit
> >>> ridiculous.
> >>
> >> Sure, but John McNamara needed it to handle flow director with IPv6[1].
> >>
> >> For my part, I was needing it to manipulate the RETA table, but as I
> >> wrote in the cover letter, it ends by breaking other commands.
> >> Olivier Matz, has proposed another way to handle long commands lines[2],
> >> it could be a good idea to go on this direction.
> >>
> >> For RETA situation, we already discussed on a new API, but for now, I
> >> do not have time for it (and as it is another ABI breakage it could only
> >> be done for 16.07 or 2.4)[3].
> >>
> >> If this patch is no more needed we can just drop it, for that I would
> >> like to have the point of view from John.
> >
> > Note that I was not objecting to the patch as such, I can easily see 256
> > characters not being enough for commandline buffer.
> >
> > I was merely noting that having to break an ABI to increase an
> > effectively internal buffer size is a sign of a, um, less-than-optimal
> > library design.
>
> You are right about the cmdline ABI. Changing this buffer size
> should not imply an ABI change. I'll try to find some time to
> investigate this issue.
>
> Another question we could raise is: should we export the API of
> librte_cmdline to external applications? Now that baremetal dpdk is
> not supported, having this library in dpdk is probably useless as
> we can surely find standard replacements for it. A first step could
> be to mark it as "internal".
>
> About the patch Nélio's patch itself, I'm not so convinced having more
> than 256 characters is absolutely required, and I would prefer to see
> the commands beeing reworked to be more human-readable. On the other
> hand, the ABI breakage was announced so there is no reason to nack
> this patch now.
>
> Regards,
> Olivier
John,
What is your position about this patch?
Is it still needed?
Regards,
--
Nélio Laranjeiro
6WIND