From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 636A55AB3 for ; Fri, 26 Feb 2016 18:36:02 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 26 Feb 2016 09:36:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="924626084" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63]) by fmsmga002.fm.intel.com with SMTP; 26 Feb 2016 09:35:59 -0800 Received: by (sSMTP sendmail emulation); Fri, 26 Feb 2016 17:35:58 +0025 Date: Fri, 26 Feb 2016 17:35:58 +0000 From: Bruce Richardson To: Liming Sun Message-ID: <20160226173558.GE28808@bricha3-MOBL3> References: <1452263948-22485-2-git-send-email-lsun@ezchip.com> <1455081321-10484-1-git-send-email-lsun@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455081321-10484-1-git-send-email-lsun@ezchip.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] driver/net/mpipe: fix the crash/hung issue when testpmd quits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 17:36:02 -0000 On Wed, Feb 10, 2016 at 12:15:21AM -0500, Liming Sun wrote: > Fixes: the hung/crash issue when quitting testpmd under high > traffic rate. The following issue were found and fixed. > 1. edesc->size is not initialized properly in mpipe_do_xmit() and could > cause buffer leak or corruption when HW buffer return is used. > 2. Check the 'idesc.be' error bit in mpipe_recv_flush() to make sure > buffer is valid before releasing it. This is to avoid issues when > running out of buffers. > 3. priv->rx_buffers counter is not accurate when HW buffer return is > used. Remove this counter to simplify the code. > > Signed-off-by: Liming Sun > Acked-by: Zhigang Lu > --- Applied to dpdk-next-net/rel_16_04 /Bruce