From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 12EA07EEF for ; Tue, 1 Mar 2016 02:02:29 +0100 (CET) Received: by mail-pa0-f47.google.com with SMTP id yy13so101286033pab.3 for ; Mon, 29 Feb 2016 17:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2njBiQMALMCcxh9VReYbCfQ8SH0QoYlMgLKbATy9Zs0=; b=CBotaKC9er0ngy+lwbOinoTikdf9I2U2CBkdp5l/w0NF8VLtCeEruHVBOMfOxhGDTN AjCrjflWawDGwTAaYy9+LuQOCPoDNJG8ixpi9+HiVbsHJKFpgVIWBsmAs81b3Va2jzCB WYr4KS7iRc/6DiFsSsDjNa3zZVi+jcODedCN3SoJ3O5KfkWPP9pMJWAGXbbZ/q6dbt0u KxdYKQKWRGZ6rRTLcskujoZh3BIAppFPK2KIfVOQoFksk3dz02hLKUAmZkzUSxdBI6H7 xcUvPTMdIAy3I6KhEqmsQdOjc79v88L4BC0N4qfJT1WphbntJ5QUAYucAhYFrKyV69dH BE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2njBiQMALMCcxh9VReYbCfQ8SH0QoYlMgLKbATy9Zs0=; b=ULS1N/16CmM8WYn2AcBrYwpcBYQy9wULzbqnIcebU1PGtfjEF63LI+5VWYk1tvTKv/ k0k+W06xKh7YBn/TcAnWZfOjACIxlPpj65jN3jlUoGUa/8g25ItUQVYfLnetN892neKj DsXwzPZ9vdmSg9I1XnjrknI4PyUztsTm9kSbfQ2LF9ycpPe8HWLd0hBCYGekM58R7BXe gl2h0TG6i8iocVAC7SaAZtoFgnRHcAtF0vlBP0v8r1ABHE0S1wos2poGYRljjJdALPtj MS7Pf+4EQ6Ihl00IfIfndSTzIc+PwqrpbTC1cNYY3bc1qdn388OmGMCSpOgHwEpuCsEj mNLg== X-Gm-Message-State: AD7BkJLjR934CD9bjdKHEuKa1FJmS2l665XiSEyhf+WP5PmEbY8yV9iII18n7LuQE5p2Lg== X-Received: by 10.67.1.209 with SMTP id bi17mr26412056pad.150.1456794148352; Mon, 29 Feb 2016 17:02:28 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id 9sm40684064pfc.69.2016.02.29.17.02.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Feb 2016 17:02:28 -0800 (PST) Date: Mon, 29 Feb 2016 17:02:41 -0800 From: Stephen Hemminger To: Ferruh Yigit Message-ID: <20160229170241.46e32284@xeon-e3> In-Reply-To: <1456495841-15749-3-git-send-email-ferruh.yigit@intel.com> References: <1455284735-9606-1-git-send-email-ferruh.yigit@intel.com> <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com> <1456495841-15749-3-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/4] kcp: add kernel control path kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 01:02:29 -0000 On Fri, 26 Feb 2016 14:10:39 +0000 Ferruh Yigit wrote: > +#define KCP_ERR(args...) printk(KERN_ERR "KCP: " args) > +#define KCP_INFO(args...) printk(KERN_INFO "KCP: " args) > + > +#ifdef RTE_KCP_KO_DEBUG > +#define KCP_DBG(args...) printk(KERN_DEBUG "KCP: " args) > +#else > +#define KCP_DBG(args...) > +#endif These macros will not make netdev developers happy. Use standard printk macros, and if you want prefix, use pr_fmt #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt