From: Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/1] arm: set CONFIG_RTE_ARCH_STRICT_ALIGN=y for armv7 target
Date: Mon, 29 Feb 2016 18:13:27 +0100 [thread overview]
Message-ID: <20160229181327.5d0307d5@pcviktorin.fit.vutbr.cz> (raw)
In-Reply-To: <20160229165538.3d3680f9@pcviktorin.fit.vutbr.cz>
On Mon, 29 Feb 2016 16:55:38 +0100
Jan Viktorin <viktorin@rehivetech.com> wrote:
> On Mon, 29 Feb 2016 16:14:58 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > 2015-12-09 16:16, Jan Viktorin:
> > > This patch reduces number of warnings from 53 to 40. It removes the usual false
> > > positives utilizing unaligned_uint*_t data types.
> > >
> > > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> >
> > Applied, thanks
> >
> > Jan, what is the problem with the other ARM alignment warnings?
> > Can they be fixed?
>
> This is the full list of warnings I can see on the current origin/master
> for ARMv7 (42 occurences) including examples (+10 more). The origin of
> all of them is:
>
> cast increases required alignment of target type [-Wcast-align]
>
> After skimming through the list, you can see that they are mostly casts
> to uint32_t * or something similar. I believe that all of them are OK.
> However, I don't know how to persuade GCC to not be angry...
>
> Probably, we can add some explicit alignment of certain structures.
>
[snip]
>
> lib/librte_vhost/vhost_user/virtio-net-user.c
> 433 rarp = (struct ether_arp *)(eth_hdr + 1);
> 527 ifr = (struct ifreq *)ifc.ifc_buf;
Fixed recently in
http://dpdk.org/browse/dpdk/commit/?id=bb66588304632a7e4a043d2921d06709d40f9ed4
>
> Regards
> Jan
prev parent reply other threads:[~2016-02-29 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 19:29 [dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access Jan Viktorin
2015-12-08 20:02 ` Stephen Hemminger
2015-12-08 20:53 ` Jan Viktorin
2015-12-08 20:30 ` Thomas Monjalon
2015-12-08 20:55 ` Jan Viktorin
2015-12-08 20:57 ` Thomas Monjalon
2015-12-08 21:17 ` Jan Viktorin
2015-12-09 15:16 ` [dpdk-dev] [PATCH 1/1] arm: set CONFIG_RTE_ARCH_STRICT_ALIGN=y for armv7 target Jan Viktorin
2016-02-29 15:14 ` Thomas Monjalon
2016-02-29 15:55 ` Jan Viktorin
2016-02-29 17:13 ` Jan Viktorin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160229181327.5d0307d5@pcviktorin.fit.vutbr.cz \
--to=viktorin@rehivetech.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).