From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 5C6509611
 for <dev@dpdk.org>; Tue,  1 Mar 2016 07:21:06 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga101.jf.intel.com with ESMTP; 29 Feb 2016 22:21:05 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,522,1449561600"; d="scan'208";a="57367838"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by fmsmga004.fm.intel.com with ESMTP; 29 Feb 2016 22:21:04 -0800
Date: Tue, 1 Mar 2016 14:22:10 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Santosh Shukla <sshukla@mvista.com>
Message-ID: <20160301062210.GO14300@yliu-dev.sh.intel.com>
References: <1456476662-23081-1-git-send-email-sshukla@mvista.com>
 <20160229042721.GJ14300@yliu-dev.sh.intel.com>
 <CAAyOgsZcug46hyS331W81Hj7gHxMU2xwCqhYWzgYY99cPYc=0Q@mail.gmail.com>
 <20160301055508.GL14300@yliu-dev.sh.intel.com>
 <CAAyOgsZJ0XDVNMMxXX06mXd2Zh09E8vJ=8-UwkmUgiuSFqURPA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAyOgsZJ0XDVNMMxXX06mXd2Zh09E8vJ=8-UwkmUgiuSFqURPA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dpdk <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] virtio: Use cpuflag for vector api
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 06:21:06 -0000

On Tue, Mar 01, 2016 at 11:40:41AM +0530, Santosh Shukla wrote:
> On Tue, Mar 1, 2016 at 11:25 AM, Yuanhan Liu
> <yuanhan.liu@linux.intel.com> wrote:
> > On Mon, Feb 29, 2016 at 06:01:38PM +0530, Santosh Shukla wrote:
> >> On Mon, Feb 29, 2016 at 9:57 AM, Yuanhan Liu
> >> <yuanhan.liu@linux.intel.com> wrote:
> >> > On Fri, Feb 26, 2016 at 02:21:02PM +0530, Santosh Shukla wrote:
> >> >> Check cpuflag macro before using vectored api.
> >> >> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added cpuflag.
> >> >> - Also wrap other vectored freind api ie..
> >> >> 1) virtqueue_enqueue_recv_refill_simple
> >> >> 2) virtio_rxq_vec_setup
> >> >>
> >> > ...
> >> >> diff --git a/drivers/net/virtio/virtio_rxtx_simple.c b/drivers/net/virtio/virtio_rxtx_simple.c
> >> >> index 3a1de9d..be51d7c 100644
> >> >> --- a/drivers/net/virtio/virtio_rxtx_simple.c
> >> >> +++ b/drivers/net/virtio/virtio_rxtx_simple.c
> >> >
> >> > Hmm, why not wrapping the whole file, instead of just few functions?
> >> >
> >>
> >> Better to refactor code and make arch specific. Current implementation
> >> is temporary.
> >
> > I'm okay to refactor, if it's a clean one. But moving virtio __driver__
> > stuff to EAL, sorry, it still doesn't make too much sense to me.
> >
> 
> You misunderstood my comment, my arch specific meaning
> driver/net/virtio/virtio_vec_<arch>.h

Oh, sorry. Then, yes, that's the way to go, if refactor is really
needed.

	--yliu