From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1B8509A81 for ; Tue, 1 Mar 2016 07:30:56 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 29 Feb 2016 22:30:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,522,1449561600"; d="scan'208";a="661626456" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by FMSMGA003.fm.intel.com with ESMTP; 29 Feb 2016 22:30:55 -0800 Date: Tue, 1 Mar 2016 14:32:01 +0800 From: Yuanhan Liu To: Santosh Shukla Message-ID: <20160301063201.GP14300@yliu-dev.sh.intel.com> References: <1456476662-23081-1-git-send-email-sshukla@mvista.com> <1456750690-3210-1-git-send-email-sshukla@mvista.com> <20160301055911.GM14300@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dpdk Subject: Re: [dpdk-dev] [PATCH v2] virtio: Use cpuflag for vector api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 06:30:57 -0000 On Tue, Mar 01, 2016 at 11:38:55AM +0530, Santosh Shukla wrote: > On Tue, Mar 1, 2016 at 11:29 AM, Yuanhan Liu > wrote: > > On Mon, Feb 29, 2016 at 06:28:10PM +0530, Santosh Shukla wrote: > >> Check cpuflag macro before using vectored api. > >> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added cpuflag. > >> - Also wrap other vectored freind api ie.. > >> 1) virtqueue_enqueue_recv_refill_simple > >> 2) virtio_rxq_vec_setup > >> > >> - removed VIRTIO_PMD=n from armv7/v8 config. > >> > >> todo: > >> 1) Move virtio_recv_pkts_vec() implementation to > >> drivers/virtio/virtio_vec_.h file. > >> 2) Remove use_simple_rxtx flag, so that virtio/virtio_vec_.h > >> files to provide vectored/non-vectored rx/tx apis. > >> > >> Signed-off-by: Santosh Shukla > >> --- > >> - v2: Removed VIRTIO_PMD=n from arm v7/v8 > > > > Firstly, I would not suggest you to send another new version, while there > > still was discussions ongoing on old version. > > > > And, you should not mix the ARM stuff here; this patch should only do > > what the patch title tells. In generic, don't do two or more things in > > one patch. > > > > w/o v2 patch, old version wont build for armv7/v8. Clubbing both in > v2, inspired from v7 virtio INC_VEC review comment/feedback [1]. Thinking it this way, that build won't work for ARM, with or without this patch. And this patch just fix a build error for platforms that doesn't has vec instructions (which could include old x86 platforms). So, the right way to go is to separate the ARM stuff to another standalone patch, claiming that we now supports ARM. Makes sense to you? BTW, is this the last piece of code to make virtio for ARM work? I maybe wrong, but I remembered you have few more patches for virtio in old versions. (Yeah, I'm aware of that the EAL parts have been merged) Anyway, here is a remind: don't forget to update release note: doc/guides/rel_notes/release_16_04.rst --yliu