From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 834A29A8A for ; Tue, 1 Mar 2016 23:37:38 +0100 (CET) Received: by mail-pf0-f182.google.com with SMTP id l6so23379217pfl.3 for ; Tue, 01 Mar 2016 14:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5eRH43d+gTKrVAb99fpz611E5s5NZrpw/6BEFnWdaEY=; b=todnyyTO9zG9z//NBFeMYgkQH0BK8miC7Hp5A9ex2jsiON8Bx6PmX0HQtpI+rkHywI 2D9RU5AB3Jo5aQOdCOCDXq34kazHboGV0LdSvnCwxu1otRPvzJcqYWj3W+I8qkXSCH41 iSwggkHlzEdLSLFsP4s7qN+SLVoII3fGLsiwtBTyHoMUbwFvytroE0/HIfWVBjl7L22R lYsurqHuaSEjjyA2amcKAblpcO+B2STMI6in8UW47K856yLUH35ZxynqAkr0EEel0H/t YdsI8NOHhvsEZ3mLU1uNqxShBnLzwEiOl1H1rFwsSMbTtXOoLtagiL9TrKudPbG0DD7B WSWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5eRH43d+gTKrVAb99fpz611E5s5NZrpw/6BEFnWdaEY=; b=RJyFRzX+sS7Bu28o8F3zC2lBwLSDICyjIznjPBzj/xM9NmEg4Ij4lICDUJ+/mwSla5 GAr95WT4TOaN6yqdl4tKDlwxkUBO5VfHWH9AC+fYqZZo7cPNLFuY+O2x86xH01HYlmAn fW3vclARgNtIyaz5HvZvXiSastIViKPjxJWHCBI5cFQiJKXeA0qoXwAUfPLo4/kJ3TiT 8i+0y8X8+xlc3fzE5c7piRJikQFC4rxEEYDAvJMhzVQNmaCmGH0uYGGeJFBCT+B1zKuw LN+reQVK5czpboZCNCURqzPOgTGjai2ySbO4QNQcW/KOGQWXA7I4OGVdJbwe7NzDl0sq Rk9A== X-Gm-Message-State: AD7BkJKv5/RLWoR3AQ+zRO6ldltuA1en3J4/n53EE0QUBPelqTZGX43oFkz60JS7bWPVmw== X-Received: by 10.98.93.211 with SMTP id n80mr34164984pfj.61.1456871857957; Tue, 01 Mar 2016 14:37:37 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id r65sm47830107pfa.27.2016.03.01.14.37.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 14:37:37 -0800 (PST) Date: Tue, 1 Mar 2016 14:37:51 -0800 From: Stephen Hemminger To: Wang Xiao W Message-ID: <20160301143751.710ef28e@xeon-e3> In-Reply-To: <1456810601-7419-2-git-send-email-xiao.w.wang@intel.com> References: <1454557129-12825-2-git-send-email-xiao.w.wang@intel.com> <1456810601-7419-1-git-send-email-xiao.w.wang@intel.com> <1456810601-7419-2-git-send-email-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/3] fm10k: enable FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 22:37:38 -0000 On Tue, 1 Mar 2016 13:36:39 +0800 Wang Xiao W wrote: > > +static int > +fm10k_check_ftag(struct rte_devargs *devargs) > +{ > + if (devargs == NULL) > + return 0; > + > + if (strstr(devargs->args, "enable_ftag=1") == NULL) > + return 0; > + > + return 1; > +} > + It is good to see the DPDK keeping up with the leading edge of hardware support. My issue is that devargs are the Linux module parameters method of configuration in the DPDK world. They are an API only a developer would love.. 1. It has to be done at boot 2. Applications have to rewrite (or expect customer) to pass args 3. Can't be changed at runtime 4. Can't be selected on per device basis. Please find a better way.