From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 054F32BB2 for ; Wed, 2 Mar 2016 00:10:45 +0100 (CET) Received: by mail-pf0-f182.google.com with SMTP id l6so23824567pfl.3 for ; Tue, 01 Mar 2016 15:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/dsGRJIC+xPfLCgmf6Vyb5gWzqYvojwspvFOr936i5w=; b=XGf4kKpXCMVo4TVX3b335vt9G4FwuZZ/J9ROtdS66GCT631i3AWLWuWktVukWRof6y dLmA8eA8DZ4Ldv+TKNY/xW7taZNZ5cxz9VnRNN2fvFhaPh6uT8Fp6qpE7pLj5oflKLhb 6GQMSFeB09Rertr/5nrEpHhgmrfxEsOZNSNzJgJiY5K8MTk+LLbNQgKvETCcsKZr2knM K/nYn7EtR7CHVVaOstOsliuG9mtx+HkitfqOACOupoHPQ06VLuCuqa+/HwOTe4KYqeu9 PVLBNptjOcjIeYazjMS2anuZDjf5woI2nPPuKAuXCBpfnCBWl/yPp+4bVFbJE68z1ich jmNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/dsGRJIC+xPfLCgmf6Vyb5gWzqYvojwspvFOr936i5w=; b=Vso8Cvmoogp8gesAFefK8i120jgiIXWuz0tPnpr24VaIIfg7IK39qXM/KPagi42jfU qkMp+B0Y2MjnrfmkMc9UQj1968a2IS96JXTixoKjEsY890LPFxR7OJpys6F4cx4GUc6+ Wquuy9GK2XXZ77iZlsgOnz368aYTUFoE3f9HDZVPDE4NEIJPyQ+WUDw8eW8HRotgbHxp gMiXrBc2lbzZbVSItFLEw0EvLuM94R+FvDgh9oqN4hEgGX5qlfGG9Z4rpC04EWiekdut SB3Pm/jeEkpNDjlZKEAp8j5Dpa7YJmlenDZNzXn1J+nQoFq3vgyjQScQk1SWK6J/cqyl oc5A== X-Gm-Message-State: AD7BkJISPGGV87zOTLKydkC4hr/3GgKp0Hc+orDGcy0CfDQw2H1wp9sDD8/kzeHKwZGMcA== X-Received: by 10.98.67.212 with SMTP id l81mr26985069pfi.112.1456873844471; Tue, 01 Mar 2016 15:10:44 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ti6sm47987135pab.4.2016.03.01.15.10.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Mar 2016 15:10:44 -0800 (PST) Date: Tue, 1 Mar 2016 15:10:58 -0800 From: Stephen Hemminger To: Ferruh Yigit Message-ID: <20160301151058.6e1731d1@xeon-e3> In-Reply-To: <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com> References: <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com> <1456846920-28770-1-git-send-email-ferruh.yigit@intel.com> <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/4] kcp: add kernel control path kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 23:10:45 -0000 On Tue, 1 Mar 2016 15:41:58 +0000 Ferruh Yigit wrote: > +struct kcp_ethtool_msg { > + int cmd_id; > + int port_id; > + unsigned int flag; > + char input_buffer[KCP_ETHTOOL_MSG_LEN]; > + char output_buffer[KCP_ETHTOOL_MSG_LEN]; > + int input_buffer_len; > + int output_buffer_len; > + int err; > +}; > + In general try and use unsigned where ever it is possible. Having int and char types was the C style back in Unix, but now most code use size_t, uint32_t and uint8_t. You seem to be trying to force ethtool into netlink. There are some others doing that already, so following their work would be good.