From: Bruce Richardson <bruce.richardson@intel.com>
To: Ravi Kerur <rkerur@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] I217 and I218 changes
Date: Tue, 1 Mar 2016 23:43:13 +0000 [thread overview]
Message-ID: <20160301234312.GC24172@bricha3-MOBL3> (raw)
In-Reply-To: <CAFb4SLCMDNsdsXn=93Jgg-fFaWFOx1EBvpgkyhgS092xaRQmVg@mail.gmail.com>
On Tue, Mar 01, 2016 at 03:37:33AM -0800, Ravi Kerur wrote:
> On Mon, Feb 29, 2016 at 9:18 PM, Lu, Wenzhuo <wenzhuo.lu@intel.com> wrote:
>
> > Hi,
> >
> > > -----Original Message-----
> > > From: Ravi Kerur [mailto:rkerur@gmail.com]
> > > Sent: Tuesday, March 1, 2016 2:31 AM
> > > To: Lu, Wenzhuo; dev@dpdk.org
> > > Cc: Ravi Kerur
> > > Subject: [PATCH v2] I217 and I218 changes
> > >
> > > v2:
> > > Incorporate Wenzhou's comments
> > > Compiled and tested (via testpmd) on Ubuntu 14.04 on target
> > > x86_64-native-linuxapp-gcc
> > > Compiled for target x86_64-native-linuxapp-clang
> > >
> > > v1:
> > > Modified driver and eal code to recognize and support I217 and
> > > I218 Intel NICs.
> > > Compiled and tested (via testpmd) on Ubuntu 14.04 for target
> > > x86_64-native-linuxapp-gcc
> > > Compiled for target x86_64-native-linuxapp-clang
> > >
> > > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> > But the v1, v2 info in the commit log is a little strange. For you didn't
> > send a v1 and others don't know our discussion :)
> >
> > Do you want me to resend it as 'v1' and include your comments in commit
> message? let me know.
>
> Thanks.
At this stage having a V1 follow a V2 would be confusing. Can you send a V3 with
a proper commit message describing the change in some detail. The v2->v3 history
please place below the cut line "---" after the signoff.
Regards,
/Bruce
next prev parent reply other threads:[~2016-03-01 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 18:30 Ravi Kerur
2016-03-01 5:18 ` Lu, Wenzhuo
2016-03-01 11:37 ` Ravi Kerur
2016-03-01 23:43 ` Bruce Richardson [this message]
2016-03-02 1:21 ` Lu, Wenzhuo
2016-03-02 14:02 ` Ravi Kerur
2016-03-02 21:22 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301234312.GC24172@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).