From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] New driver (large patch) question.
Date: Wed, 2 Mar 2016 08:24:50 -0800 [thread overview]
Message-ID: <20160302082450.6f64cf8e@xeon-e3> (raw)
In-Reply-To: <2110917.95LWFiBeeK@xps13>
On Wed, 02 Mar 2016 11:21:26 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> Hi,
>
> 2016-03-01 19:56, Stephen Hurd:
> > I submitted a new driver on Friday, and it was rejected for being over 300k.
> >
> > The rejection email suggested contacing dev-owner@dpdk.org, which I did on
> > Monday with no reply.
> >
> > What's the process to submit patches larger than the mailing list size
> > limit?
>
> A patch has two lives:
> 1/ it must be reviewed and accepted
> 2/ it will stay in the git history for future reference
>
> Those 2 periods require the patch to be well explained, with a
> reasonnable scope and a human readable size.
> The primary rule to think about is to introduce only one feature
> per patch.
> So the size should be naturally small and the mailing list don't need
> to accept greater sizes.
>
> To make it short, please split your driver in several introduction steps.
>
Too many of the DPDK drivers are bloated.
Recall the venerable paraphrase of Pascal, "I made this so long because I did not have time to make it shorter."
https://en.wikipedia.org/wiki/Wikipedia:Too_long;_didn%27t_read
Linux went through similar stages. Many drivers ended up being rewritten
for brevity (e1000, skge, tg3). Vendor drivers seem to want to engage all features
even if they have no value.
next prev parent reply other threads:[~2016-03-02 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJ9nmBaWh8WsuzQcAfrebjaFNYSGsGxEd5Y5DQfWTPuxYY8XWQ@mail.gmail.com>
2016-03-02 10:21 ` Thomas Monjalon
2016-03-02 16:24 ` Stephen Hemminger [this message]
2016-03-02 21:30 ` Stephen Hurd
2016-03-02 21:54 ` Thomas Monjalon
2016-03-02 22:06 ` Stephen Hurd
2016-03-02 22:12 ` Wiles, Keith
2016-03-02 22:15 ` Thomas Monjalon
2016-03-02 23:10 ` Stephen Hurd
2016-03-03 0:29 ` Thomas Monjalon
2016-03-03 1:04 ` Stephen Hurd
2016-03-03 5:53 ` Qiu, Michael
2016-03-03 19:40 ` Stephen Hurd
2016-03-02 23:07 ` Vincent JARDIN
2016-03-02 23:43 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302082450.6f64cf8e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).