From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id D65B869FF for ; Wed, 2 Mar 2016 17:24:41 +0100 (CET) Received: by mail-pa0-f42.google.com with SMTP id a9so13716301pat.3 for ; Wed, 02 Mar 2016 08:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gNIozl0uwLb4TrQbcTEz3wASc1+ddKwtBweErGrbxLA=; b=xfc7h9ZGU4u1tuTXxyqRbJjDZjwNDbAnUDwYCfSrpJQSSCWJ6J8PmDLIrUemGaKn9U /ZP9CT9zxOCcpxizTioNaMVidJWxguD6whc33SQh7etYYOBnQPni2ro4Kag0jLun1dxX Mivm+i3nDRQtJI96C7qVIC04iX71c1Y8ybS14MtCNEN1fwMmEZnHDI7cG+iX+TX8Imax CyrXJrEIPDt4IDO93N22bucFo5mgwJt6hHH5fNoKZEa3CbNkqLnk7HHBZu06oRSWZ4fl MB0xOvbmeFil3aNayUNdl3s63AX90g2/zf4e0QsZWaQF03y48QHGSQ5f/x3MyLbIkb95 twLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gNIozl0uwLb4TrQbcTEz3wASc1+ddKwtBweErGrbxLA=; b=DQ2+I+ISerL/h7OmqdVdyP685fUesmCOW4Cvg7YGlbj+zPWrH2xpggWvx2ftb/vRZJ ITcCM2BWS+3q5Q+ER3MA8BlndRMF8zqwvbmdT335aKZR6tsYViYqKsp+UJQlJHTDq0XP ewvGkNs7RsZR1C9upmehb9tf5Mx8/x147iaUwB98q0NUeajRvN80uRS6lKcj+y6Sc/eb d65qKFNK+gi2BxEMnqIRJC5pgJDwSUuDire1csKbzTDUi+A2MjauixpwsoEhIaMe7+Cw f8Hn58aWyLPdFB39YsSlZLltqCfwphTm+Dw2JX9DSxU4veGsLhbfXAwsTPD+rXoLWEPp qFEg== X-Gm-Message-State: AD7BkJIl6UTSYuilfu2w8aFM76rLc+dCCnGYH2VpRsBiV5/JVLa3wvySnag5L+yhqansDQ== X-Received: by 10.67.8.100 with SMTP id dj4mr40045375pad.88.1456935881291; Wed, 02 Mar 2016 08:24:41 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ko9sm54190703pab.37.2016.03.02.08.24.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Mar 2016 08:24:40 -0800 (PST) Date: Wed, 2 Mar 2016 08:24:50 -0800 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20160302082450.6f64cf8e@xeon-e3> In-Reply-To: <2110917.95LWFiBeeK@xps13> References: <2110917.95LWFiBeeK@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 16:24:42 -0000 On Wed, 02 Mar 2016 11:21:26 +0100 Thomas Monjalon wrote: > Hi, > > 2016-03-01 19:56, Stephen Hurd: > > I submitted a new driver on Friday, and it was rejected for being over 300k. > > > > The rejection email suggested contacing dev-owner@dpdk.org, which I did on > > Monday with no reply. > > > > What's the process to submit patches larger than the mailing list size > > limit? > > A patch has two lives: > 1/ it must be reviewed and accepted > 2/ it will stay in the git history for future reference > > Those 2 periods require the patch to be well explained, with a > reasonnable scope and a human readable size. > The primary rule to think about is to introduce only one feature > per patch. > So the size should be naturally small and the mailing list don't need > to accept greater sizes. > > To make it short, please split your driver in several introduction steps. > Too many of the DPDK drivers are bloated. Recall the venerable paraphrase of Pascal, "I made this so long because I did not have time to make it shorter." https://en.wikipedia.org/wiki/Wikipedia:Too_long;_didn%27t_read Linux went through similar stages. Many drivers ended up being rewritten for brevity (e1000, skge, tg3). Vendor drivers seem to want to engage all features even if they have no value.