From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id B921736E
 for <dev@dpdk.org>; Wed,  2 Mar 2016 23:05:18 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga104.fm.intel.com with ESMTP; 02 Mar 2016 14:04:56 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,530,1449561600"; d="scan'208";a="915585299"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.122.40.66])
 by fmsmga001.fm.intel.com with SMTP; 02 Mar 2016 14:04:54 -0800
Received: by  (sSMTP sendmail emulation); Wed, 02 Mar 2016 22:04:54 +0025
Date: Wed, 2 Mar 2016 22:04:54 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160302220453.GE8804@bricha3-MOBL3>
References: <9190554.3JBlDK3N1R@xps13>
 <1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] mk: stop on warning only in developer
	build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2016 22:05:19 -0000

On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote:
> From: Panu Matilainen <pmatilai@redhat.com>
> 
> Add RTE_DEVEL_BUILD make-variable which can be used to do things
> differently when doing development vs building a release,
> autodetected from source root .git presence and overridable via
> commandline. It is used it to enable -Werror compiler flag and may
> be extended to other checks.
> 
> Failing build on warnings is a useful developer tool but its bad
> for release tarballs which can and do get built with newer
> compilers than what was used/available during development. Compilers
> routinely add new warnings so code which built silently with cc X
> might no longer do so with X+1. This doesn't make the existing code
> any more buggier and failing the build in this case does not help
> to improve the quality of an already released version either.
> 
> This change the default flags which can be tuned with EXTRA_CFLAGS.
> 
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>