From: Stephen Hemminger <stephen@networkplumber.org>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt
Date: Fri, 4 Mar 2016 15:02:07 -0800 [thread overview]
Message-ID: <20160304150207.49d859f4@xeon-e3> (raw)
In-Reply-To: <1457125528-128877-4-git-send-email-stephen.hurd@broadcom.com>
On Fri, 4 Mar 2016 13:05:24 -0800
Stephen Hurd <stephen.hurd@broadcom.com> wrote:
> New driver for Broadcom bnxt (NexXtreme C-series) devices.
>
> Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput
> http://www.broadcom.com/press/release.php?id=s923886
>
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> ---
> v3:
> * Fix incorrect format specifier compilation error on i686
> (PRIx64 instead of lx for uint64_t) on line 1337
>
> drivers/net/bnxt/Makefile | 79 ++
> drivers/net/bnxt/bnxt.h | 217 ++++
> drivers/net/bnxt/bnxt_cpr.c | 138 +++
> drivers/net/bnxt/bnxt_cpr.h | 117 ++
> drivers/net/bnxt/bnxt_ethdev.c | 1381 ++++++++++++++++++++++
> drivers/net/bnxt/bnxt_filter.c | 175 +++
> drivers/net/bnxt/bnxt_filter.h | 74 ++
> drivers/net/bnxt/bnxt_hwrm.c | 1554 ++++++++++++++++++++++++
> drivers/net/bnxt/bnxt_hwrm.h | 105 ++
> drivers/net/bnxt/bnxt_irq.c | 154 +++
> drivers/net/bnxt/bnxt_irq.h | 51 +
> drivers/net/bnxt/bnxt_ring.c | 306 +++++
> drivers/net/bnxt/bnxt_ring.h | 104 ++
> drivers/net/bnxt/bnxt_rxq.c | 383 ++++++
> drivers/net/bnxt/bnxt_rxq.h | 75 ++
> drivers/net/bnxt/bnxt_rxr.c | 369 ++++++
> drivers/net/bnxt/bnxt_rxr.h | 73 ++
> drivers/net/bnxt/bnxt_stats.c | 190 +++
> drivers/net/bnxt/bnxt_stats.h | 44 +
> drivers/net/bnxt/bnxt_txq.c | 164 +++
> drivers/net/bnxt/bnxt_txq.h | 76 ++
> drivers/net/bnxt/bnxt_txr.c | 326 +++++
> drivers/net/bnxt/bnxt_txr.h | 71 ++
> drivers/net/bnxt/bnxt_vnic.c | 285 +++++
> drivers/net/bnxt/bnxt_vnic.h | 80 ++
> drivers/net/bnxt/hsi_struct_def_dpdk.h | 1832 +++++++++++++++++++++++++++++
> drivers/net/bnxt/rte_pmd_bnxt_version.map | 4 +
> 27 files changed, 8427 insertions(+)
> create mode 100644 drivers/net/bnxt/Makefile
> create mode 100644 drivers/net/bnxt/bnxt.h
> create mode 100644 drivers/net/bnxt/bnxt_cpr.c
> create mode 100644 drivers/net/bnxt/bnxt_cpr.h
> create mode 100644 drivers/net/bnxt/bnxt_ethdev.c
> create mode 100644 drivers/net/bnxt/bnxt_filter.c
> create mode 100644 drivers/net/bnxt/bnxt_filter.h
> create mode 100644 drivers/net/bnxt/bnxt_hwrm.c
> create mode 100644 drivers/net/bnxt/bnxt_hwrm.h
> create mode 100644 drivers/net/bnxt/bnxt_irq.c
> create mode 100644 drivers/net/bnxt/bnxt_irq.h
> create mode 100644 drivers/net/bnxt/bnxt_ring.c
> create mode 100644 drivers/net/bnxt/bnxt_ring.h
> create mode 100644 drivers/net/bnxt/bnxt_rxq.c
> create mode 100644 drivers/net/bnxt/bnxt_rxq.h
> create mode 100644 drivers/net/bnxt/bnxt_rxr.c
> create mode 100644 drivers/net/bnxt/bnxt_rxr.h
> create mode 100644 drivers/net/bnxt/bnxt_stats.c
> create mode 100644 drivers/net/bnxt/bnxt_stats.h
> create mode 100644 drivers/net/bnxt/bnxt_txq.c
> create mode 100644 drivers/net/bnxt/bnxt_txq.h
> create mode 100644 drivers/net/bnxt/bnxt_txr.c
> create mode 100644 drivers/net/bnxt/bnxt_txr.h
> create mode 100644 drivers/net/bnxt/bnxt_vnic.c
> create mode 100644 drivers/net/bnxt/bnxt_vnic.h
> create mode 100644 drivers/net/bnxt/hsi_struct_def_dpdk.h
> create mode 100644 drivers/net/bnxt/rte_pmd_bnxt_version.map
Looks good, I just have a couple of functionality comments.
1. Driver does not appear to support Link State interrupt. Not a big
deal, but would be good to have.
2. Driver does not support hotplug
3. Since driver does not support scattered receive, it should check
and error out on enable_scatter (ditto for other features in rxmode).
This will save pain in future when some application asks device to do
something it can not do.
4. Does driver support SECONDARY process model, it appears secondary
device will reset hardware.
5. Driver does not supper per-receive queue data interrupts.
This is necessary for power-saving NAPI like code.
next prev parent reply other threads:[~2016-03-04 23:01 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 21:36 [dpdk-dev] [PATCH] drivers/net/bnxt New " Stephen Hurd
2016-03-02 21:44 ` Stephen Hemminger
2016-03-02 21:58 ` Thomas Monjalon
2016-03-03 4:08 ` [dpdk-dev] [PATCH 0/7] drivers/net/bnxt: new Broadcom bnxt driver Stephen Hurd
2016-03-03 4:08 ` [dpdk-dev] [PATCH 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds Stephen Hurd
2016-03-03 7:53 ` Simon Kågström
2016-03-03 9:28 ` Thomas Monjalon
2016-03-03 10:22 ` Simon Kågström
2016-03-03 4:08 ` [dpdk-dev] [PATCH 2/7] lib/librte_eal: Add PCI IDs for Broadcom bnxt Stephen Hurd
2016-03-03 4:08 ` [dpdk-dev] [PATCH 3/7] drivers/net/bnxt new driver " Stephen Hurd
2016-03-03 4:08 ` [dpdk-dev] [PATCH 4/7] maintainers: claim drivers/net/bnxt Stephen Hurd
2016-03-03 4:08 ` [dpdk-dev] [PATCH 5/7] build: add bnxt PMD to build Stephen Hurd
2016-03-03 4:08 ` [dpdk-dev] [PATCH 6/7] doc: Add bnxt to overview table Stephen Hurd
2016-03-03 4:08 ` [dpdk-dev] [PATCH 7/7] doc: add guide for new bnxt driver Stephen Hurd
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 0/7] drivers/net/bnxt: new Broadcom " Stephen Hurd
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds Stephen Hurd
2016-04-19 12:41 ` Bruce Richardson
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 2/7] lib/librte_eal: Add PCI IDs for Broadcom bnxt Stephen Hurd
2016-04-19 13:01 ` Bruce Richardson
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver " Stephen Hurd
2016-03-04 23:02 ` Stephen Hemminger [this message]
2016-03-04 23:58 ` Stephen Hurd
2016-04-19 14:19 ` Bruce Richardson
2016-04-19 20:51 ` Stephen Hurd
2016-04-20 11:01 ` Bruce Richardson
2016-04-20 21:32 ` Stephen Hurd
2016-04-21 10:00 ` Bruce Richardson
2016-04-21 10:11 ` Thomas Monjalon
2016-05-06 19:25 ` [dpdk-dev] [PATCH 01/40] bnxt: new driver for Broadcom NetXtreme-C devices Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 02/40] bnxt: add HWRM init code Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 03/40] bnxt: add driver register/unregister support Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 04/40] bnxt: add dev infos get operation Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 05/40] bnxt: add dev configure operation Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 06/40] bnxt: add vnic functions and structs Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 07/40] bnxt: declare ring structs and free() func Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 08/40] bnxt: add completion ring support Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 09/40] bnxt: add L2 filter alloc/init/free Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 10/40] bnxt: add Tx queue operations (nonfunctional) Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 11/40] bnxt: add Rx queue create/destroy operations Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 12/40] bnxt: statistics operations Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 13/40] bnxt: initial Tx ring code Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 14/40] bnxt: initial Rx " Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 15/40] bnxt: alloc/free ring information Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 16/40] bnxt: add HWRM function reset command Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 17/40] bnxt: add HWRM vnic alloc function Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 18/40] bnxt: add HWRM vnic free function Stephen Hurd
2016-05-06 19:25 ` [dpdk-dev] [PATCH 19/40] bnxt: add HWRM vnic cfg function Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 20/40] bnxt: add vnic RSS cos lb cTx alloc/free functions Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 21/40] bnxt: add HWRM vnic RSS config function Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 22/40] bnxt: add L2 Rx mask set/clear functions Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 23/40] bnxt: add HWRM stats context allocation Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 24/40] bnxt: add HWRM ring alloc/free functions Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 25/40] bnxt: add ring group " Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 26/40] bnxt: add HWRM stat context free function Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 27/40] bnxt: add struct forward decl Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 28/40] bnxt: add ring allocation and group init Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 29/40] bnxt: work around HWRM error when creating rings Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 30/40] bnxt: add HWRM port phy qcfg call and wrapper Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 31/40] bnxt: add start/stop/link update operations Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 32/40] bnxt: add promiscuous enable/disable operations Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 33/40] bnxt: add all multicast " Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 34/40] bnxt: add device close operation Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 35/40] bnxt: add MAC address add/remove operations Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 36/40] bnxt: add dev set link up/down operations Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 37/40] bnxt: add reta update/query operations Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 38/40] bnxt: add RSS device operations Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 39/40] bnxt: add flow control operations Stephen Hurd
2016-05-06 19:26 ` [dpdk-dev] [PATCH 40/40] bnxt: cleanup null pointer checks Stephen Hurd
2016-05-11 4:53 ` [dpdk-dev] [PATCH 01/40] bnxt: new driver for Broadcom NetXtreme-C devices Panu Matilainen
2016-05-11 20:59 ` Stephen Hurd
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 " Stephen Hurd
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 02/40] bnxt: add HWRM init code Stephen Hurd
2016-05-25 15:05 ` Bruce Richardson
2016-05-25 23:35 ` Stephen Hurd
2016-05-26 9:01 ` Bruce Richardson
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 03/40] bnxt: add driver register/unregister support Stephen Hurd
2016-05-25 15:11 ` Bruce Richardson
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 04/40] bnxt: add dev infos get operation Stephen Hurd
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 05/40] bnxt: add dev configure operation Stephen Hurd
2016-05-25 15:25 ` Bruce Richardson
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 06/40] bnxt: add vnic functions and structs Stephen Hurd
2016-05-25 16:14 ` Bruce Richardson
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 07/40] bnxt: declare ring structs and free() func Stephen Hurd
2016-05-25 16:37 ` Bruce Richardson
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 08/40] bnxt: add completion ring support Stephen Hurd
2016-05-25 17:33 ` Bruce Richardson
2016-05-26 9:38 ` Bruce Richardson
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 09/40] bnxt: add L2 filter alloc/init/free Stephen Hurd
2016-05-25 17:51 ` Bruce Richardson
2016-05-13 22:45 ` [dpdk-dev] [PATCH v2 10/40] bnxt: add Tx queue operations (nonfunctional) Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 11/40] bnxt: add Rx queue create/destroy operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 12/40] bnxt: statistics operations Stephen Hurd
2016-05-26 9:40 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 13/40] bnxt: initial Tx ring code Stephen Hurd
2016-05-26 10:40 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 14/40] bnxt: initial Rx " Stephen Hurd
2016-05-26 10:52 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 15/40] bnxt: alloc/free ring information Stephen Hurd
2016-05-26 10:59 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 16/40] bnxt: add HWRM function reset command Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 17/40] bnxt: add HWRM vnic alloc function Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 18/40] bnxt: add HWRM vnic free function Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 19/40] bnxt: add HWRM vnic cfg function Stephen Hurd
2016-05-26 12:04 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 20/40] bnxt: add vnic RSS cos lb cTx alloc/free functions Stephen Hurd
2016-05-26 12:06 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 21/40] bnxt: add HWRM vnic RSS config function Stephen Hurd
2016-05-26 12:14 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 22/40] bnxt: add L2 Rx mask set/clear functions Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 23/40] bnxt: add HWRM stats context allocation Stephen Hurd
2016-05-26 12:23 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 24/40] bnxt: add HWRM ring alloc/free functions Stephen Hurd
2016-05-26 12:45 ` Bruce Richardson
2016-05-26 13:19 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 25/40] bnxt: add ring group " Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 26/40] bnxt: add HWRM stat context free function Stephen Hurd
2016-05-26 13:15 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 27/40] bnxt: add struct forward decl Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 28/40] bnxt: add ring allocation and group init Stephen Hurd
2016-05-26 13:24 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 29/40] bnxt: work around HWRM error when creating rings Stephen Hurd
2016-05-26 13:25 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 30/40] bnxt: add HWRM port phy qcfg call and wrapper Stephen Hurd
2016-05-26 13:39 ` Bruce Richardson
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 31/40] bnxt: add start/stop/link update operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 32/40] bnxt: add promiscuous enable/disable operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 33/40] bnxt: add all multicast " Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 34/40] bnxt: add device close operation Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 35/40] bnxt: add MAC address add/remove operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 36/40] bnxt: add dev set link up/down operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 37/40] bnxt: add reta update/query operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 38/40] bnxt: add RSS device operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 39/40] bnxt: add flow control operations Stephen Hurd
2016-05-13 22:46 ` [dpdk-dev] [PATCH v2 40/40] bnxt: cleanup null pointer checks Stephen Hurd
2016-05-26 15:20 ` Bruce Richardson
2016-05-25 15:02 ` [dpdk-dev] [PATCH v2 01/40] bnxt: new driver for Broadcom NetXtreme-C devices Bruce Richardson
2016-05-25 20:59 ` Stephen Hurd
2016-05-26 9:05 ` Bruce Richardson
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 4/7] maintainers: claim drivers/net/bnxt Stephen Hurd
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 5/7] build: add bnxt PMD to build Stephen Hurd
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 6/7] doc: Add bnxt to overview table Stephen Hurd
2016-03-04 21:05 ` [dpdk-dev] [PATCH v3 7/7] doc: add guide for new bnxt driver Stephen Hurd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304150207.49d859f4@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=stephen.hurd@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).