From: Stephen Hemminger <stephen@networkplumber.org>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions
Date: Mon, 7 Mar 2016 11:19:33 -0800 [thread overview]
Message-ID: <20160307111933.5a6c8ebf@xeon-e3> (raw)
In-Reply-To: <56DDB50C.5040203@intel.com>
On Mon, 07 Mar 2016 17:06:20 +0000
Remy Horton <remy.horton@intel.com> wrote:
>
>
> On 07/03/2016 16:07, Stephen Hemminger wrote:
> >> That version doesn't include a MAC address sanity check - is such a
> >> check redundant (or incorrect) in this case?
> >>
> >> ..Remy
> >
> > That belongs in common code, not in each driver.
>
> That differs from previous feedback for a different driver, where such a
> check was actually asked to be added.. :/
>
> Probably need to audit the upstream functions for such checks.
>
> ..Remy
Probably need checks in both places. Zero is bad for any device,
some devices allow multicast addresses as MAC, and some clustering
seemed to want it.
next prev parent reply other threads:[~2016-03-07 19:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 8:48 [dpdk-dev] [PATCH v1 0/3] Add missing ethdev driver support Remy Horton
2016-01-28 8:48 ` [dpdk-dev] [PATCH v1 1/3] drivers/net/i40e: Add ethdev functions Remy Horton
2016-02-23 2:06 ` Zhang, Helin
2016-02-24 10:32 ` Remy Horton
2016-02-24 10:43 ` Ananyev, Konstantin
2016-01-28 8:48 ` [dpdk-dev] [PATCH v1 2/3] drivers/net/virtio: " Remy Horton
2016-01-28 8:48 ` [dpdk-dev] [PATCH v1 3/3] drivers/net/vmxnet3: " Remy Horton
2016-02-16 23:42 ` Yong Wang
2016-02-16 12:02 ` [dpdk-dev] [PATCH v1 0/3] Add missing ethdev driver support Bruce Richardson
2016-02-16 18:54 ` Stephen Hemminger
2016-02-23 12:19 ` Remy Horton
2016-03-04 15:25 ` [dpdk-dev] [PATCH v2 0/2] " Remy Horton
2016-03-04 15:25 ` [dpdk-dev] [PATCH v2 1/2] drivers/net/i40e: add ethdev functions Remy Horton
2016-03-04 15:25 ` [dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: " Remy Horton
2016-03-04 19:12 ` Yong Wang
2016-03-04 20:34 ` Stephen Hemminger
2016-03-07 12:26 ` Remy Horton
[not found] ` <20160307080747.02cc1f1b@xeon-e3>
2016-03-07 17:06 ` Remy Horton
2016-03-07 19:19 ` Stephen Hemminger [this message]
2016-03-09 13:29 ` [dpdk-dev] [PATCH v3 0/1] Add missing ethdev driver support Remy Horton
2016-03-09 13:29 ` [dpdk-dev] [PATCH v3 1/1] drivers/net/i40e: add ethdev functions Remy Horton
2016-03-10 12:25 ` Mcnamara, John
2016-03-14 10:22 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307111933.5a6c8ebf@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).