From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 459DB11D4 for ; Mon, 7 Mar 2016 20:19:20 +0100 (CET) Received: by mail-pa0-f43.google.com with SMTP id tt10so21477708pab.3 for ; Mon, 07 Mar 2016 11:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FfcBRNw+DRLb+Zw7iyV5xKEtYzg+x41xlM5ReiWBgPk=; b=fWbMSGMmEfZC4cOHJFPtjOsL3h1tdYcvG3bWU+Em0ZyTR35+lkElQX3qkNvEhWStq1 w3I4avkAxrJlQzJtMuHwCdYefXoYwf5B2JIJgwwi0UaQ1o0WfsNUgZNSuAZvXlE9OHaC j1QsNILJtMeDLOeY4JRDbSsVFlNxqJAIPYYvF3EQ8FlJ0qVRmGiMxW3R8U83SsB/r+6s tP+MKiLjYqjQYHLoyfJ9y9cwMnx+lJfBSLJnMgcHUO50CMUnU7Gr9XDLh0IazZ7ls5/r Y/TPePS/rjhj+AqugOtBcJATqzU8ZXnp5R3WmNzkLpxWSPhMkjwJLsDn8WTibRlTPDOz vBtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FfcBRNw+DRLb+Zw7iyV5xKEtYzg+x41xlM5ReiWBgPk=; b=C3Z74UJolgcsLRq130O7aH3FoGhr1pSy3OqhN2ZN6qY1cyWhUb9I45T2J61xuo/z7j UyNN2aYJRoCmPv1a1rASId9r4HBMWmToCJe3XCK+Kl9NizdZHI5lp6ubuHkRhF4q2JuA tliqeOKvXYSzMOXRGvBTNX2gHJO8Nft5TZ19Tv/RCG0brZ8qKPwM2myOSiynHFFeHr1L hQxTLEEfSiVYopVrHvsu7zmadP13fF/HWPPSI9ZaWYOHKaP5uK0R3MrykGn4wgUCcoNv DDwMvna6nDVou5Aw6Jzs/KdQnZLvaIk5h34xcx6GbiHMpqvtPhBieuYq1gfN0kYtFdRK a+kQ== X-Gm-Message-State: AD7BkJJZA+j6GCoLqVTMQQ74EcgPVAJMsDW7yBtsd4g2VAmN97cp6tsYSGN1BSm7DItAmg== X-Received: by 10.66.131.69 with SMTP id ok5mr35623352pab.96.1457378359682; Mon, 07 Mar 2016 11:19:19 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id h19sm25780746pfh.43.2016.03.07.11.19.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Mar 2016 11:19:19 -0800 (PST) Date: Mon, 7 Mar 2016 11:19:33 -0800 From: Stephen Hemminger To: Remy Horton Message-ID: <20160307111933.5a6c8ebf@xeon-e3> In-Reply-To: <56DDB50C.5040203@intel.com> References: <1457105124-23650-1-git-send-email-remy.horton@intel.com> <1457105124-23650-3-git-send-email-remy.horton@intel.com> <20160304123452.047709c2@xeon-e3> <56DD7365.7050002@intel.com> <20160307080747.02cc1f1b@xeon-e3> <56DDB50C.5040203@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2016 19:19:20 -0000 On Mon, 07 Mar 2016 17:06:20 +0000 Remy Horton wrote: > > > On 07/03/2016 16:07, Stephen Hemminger wrote: > >> That version doesn't include a MAC address sanity check - is such a > >> check redundant (or incorrect) in this case? > >> > >> ..Remy > > > > That belongs in common code, not in each driver. > > That differs from previous feedback for a different driver, where such a > check was actually asked to be added.. :/ > > Probably need to audit the upstream functions for such checks. > > ..Remy Probably need checks in both places. Zero is bad for any device, some devices allow multicast addresses as MAC, and some clustering seemed to want it.