From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 94B002C65 for ; Mon, 7 Mar 2016 13:41:13 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 07 Mar 2016 04:41:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,551,1449561600"; d="scan'208";a="918516414" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.65]) by fmsmga001.fm.intel.com with SMTP; 07 Mar 2016 04:41:08 -0800 Received: by (sSMTP sendmail emulation); Mon, 07 Mar 2016 12:41:07 +0025 Date: Mon, 7 Mar 2016 12:41:07 +0000 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20160307124107.GA16816@bricha3-MOBL3> References: <121442835.2vdhmXQbJs@xps13> <1982157.64YrbiQtVx@xps13> <56DB83D9.3030009@intel.com> <5474006.zCJzWiptFr@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5474006.zCJzWiptFr@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] config: remove duplicate configuration information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2016 12:41:14 -0000 On Sun, Mar 06, 2016 at 10:35:50AM +0100, Thomas Monjalon wrote: > 2016-03-06 01:11, Ferruh Yigit: > > On 3/4/2016 10:43 PM, Thomas Monjalon wrote: > > > 2016-03-04 12:11, Keith Wiles: > > >> In order to cleanup the configuration files some and reduce > > >> the number of duplicate configuration information. Add a new > > >> file called common_base which contains just about all of the > > >> configuration lines in one place. Then have the common_bsdapp, > > >> common_linuxapp files include this one file. Then in those OS > > >> specific files add the delta configuration lines. > > >> > > >> Signed-off-by: Keith Wiles > > > > > > It's also fixing the crypto settings which were mispelled for BSD. > > > > > > Applied with few cosmetic adjustments, thanks. > > > > > This is already applied, but, > > > > Is it required to keep Linux specific features > > (igb_uio/vfio/kni/vhost..) in base config? Why not move all to Linux > > only config? > > I have no strong opinion. > Keeping them in the base file makes easy to list every options. > On the other hand, we already have MPIPE defined only in tilegx config > and CONTIGEM only in bsdapp. > > > Because they show up in final bsd config, which is unnecessary. Also > > they show up in final Linux config twice, first one disables feature and > > second one enables back. Although this works fine both for bsd and > > Linux, it is confusing. > I prefer to have them in, so that the base config shows all config options. Otherwise if a config option only used on one platform suddenly becomes used on a second one, we need to start patching the base config to move it from a platform-specific one to a common one. [Or worse, we start having cases where we have to make a judgement call as to whether something is a common option or not!] /Bruce