From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: support multicast promiscuous mode on VF
Date: Tue, 8 Mar 2016 13:37:52 +0000 [thread overview]
Message-ID: <20160308133752.GD8716@bricha3-MOBL3> (raw)
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF403DBAE795@SHSMSX101.ccr.corp.intel.com>
On Thu, Mar 03, 2016 at 03:51:25AM +0000, Wang, Xiao W wrote:
> Hi,
>
> > > > +
> > > > + err = mbx->ops.write_posted(hw, msgbuf, 2, 0);
> > > > + if (err)
> > > > + return err;
> > > > +
> > > > + err = mbx->ops.read_posted(hw, msgbuf, 2, 0);
> > >
> > > Is it more reasonable to read a message of size 1 than 2? Pf side only
> > > write 1 word into mbx.
> > Thanks for the comment. But actually PF writes 16 words into the mbx, and 2
> > words have meaning.
> > Word0 is used to check ack/nack. PF uses word1 to write the xcast_mode back.
> > I don't check the word1 because I don't see the necessary:)
> >
> > >
>
> OK, I learned that kernel PF put 2 words into mbx for this message.
>
> Acked-by: Xiao Wang <xiao.w.wang@intel.com>
Applied to dpdk-next-net/rel_16_04
/Bruce
next prev parent reply other threads:[~2016-03-08 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 8:43 Lu, Wenzhuo
2016-03-03 3:51 ` Wang, Xiao W
2016-03-08 13:37 ` Bruce Richardson [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-04 8:07 [dpdk-dev] [PATCH] " Wenzhuo Lu
2016-02-14 6:24 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2016-02-15 8:09 ` Wang, Xiao W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308133752.GD8716@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).