From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 9E0AB2906
 for <dev@dpdk.org>; Tue,  8 Mar 2016 14:37:56 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 08 Mar 2016 05:37:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,556,1449561600"; d="scan'208";a="929321131"
Received: from ipdaly-mobl3.ger.corp.intel.com ([10.252.0.87])
 by orsmga002.jf.intel.com with SMTP; 08 Mar 2016 05:37:53 -0800
Received: by  (sSMTP sendmail emulation); Tue, 08 Mar 2016 13:37:52 +0025
Date: Tue, 8 Mar 2016 13:37:52 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Message-ID: <20160308133752.GD8716@bricha3-MOBL3>
References: <6A0DE07E22DDAD4C9103DF62FEBC09090342A9EA@shsmsx102.ccr.corp.intel.com>
 <B7F2E978279D1D49A3034B7786DACF403DBAE795@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF403DBAE795@SHSMSX101.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: support multicast promiscuous mode
 on VF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 13:37:57 -0000

On Thu, Mar 03, 2016 at 03:51:25AM +0000, Wang, Xiao W wrote:
> Hi,
> 
> > > > +
> > > > +	err = mbx->ops.write_posted(hw, msgbuf, 2, 0);
> > > > +	if (err)
> > > > +		return err;
> > > > +
> > > > +	err = mbx->ops.read_posted(hw, msgbuf, 2, 0);
> > >
> > > Is it more reasonable to read a message of size 1 than 2? Pf side only
> > > write 1 word into mbx.
> > Thanks for the comment. But actually PF writes 16 words into the mbx, and 2
> > words have meaning.
> > Word0 is used to check ack/nack. PF uses word1 to write the xcast_mode back.
> > I don't check the word1 because I don't see the necessary:)
> > 
> > >
> 
> OK, I learned that kernel PF put 2 words into mbx for this message.
> 
> Acked-by: Xiao Wang <xiao.w.wang@intel.com>

Applied to dpdk-next-net/rel_16_04

/Bruce