From: Bruce Richardson <bruce.richardson@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] ixgbe: support link speed auto-neg on x550em_x
Date: Tue, 8 Mar 2016 17:34:33 +0000 [thread overview]
Message-ID: <20160308173433.GB6324@bricha3-MOBL3> (raw)
In-Reply-To: <1456455930-16124-1-git-send-email-wenzhuo.lu@intel.com>
On Fri, Feb 26, 2016 at 11:05:29AM +0800, Wenzhuo Lu wrote:
> Normally the auto-negotiation is supported by FW. SW need not care about
> that. But on x550em_x, FW doesn't support auto-neg. As the ports of x550em_x
> are 10G, if we connect the port will a peer which is 1G, the link will always
> be down.
> We need support auto-neg by SW to avoid this link down issue. As we already
> have the code to handle the link speed setting, what we need is a trigger.
> When the advertised link speed changes, a PHY interruption will be triggered.
> So, we should handle this interruption and call ixgbe_handle_lasi to set the
> link speed correctly.
>
> Please be aware it's working when auto-neg is on. If the auto-neg of the peer
> port is turned off and its speed is indicated manually, we should also set
> the speed of our own port manually.
>
> V2:
> *Fix the wrong signoff name.
>
> V3:
> *Change the tittle and add the explanation of the implementation in commit log.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Shaopeng He <shaopeng.he@intel.com>
> ---
Applied to dpdk-next-net/rel_16_04
/Bruce
prev parent reply other threads:[~2016-03-08 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 7:56 [dpdk-dev] [PATCH] ixgbe: fix link down issue " Wenzhuo Lu
2016-02-01 8:22 ` He, Shaopeng
2016-02-01 8:26 ` Lu, Wenzhuo
2016-02-01 8:42 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2016-02-04 6:21 ` He, Shaopeng
2016-02-24 14:26 ` Bruce Richardson
2016-02-25 1:32 ` Lu, Wenzhuo
2016-02-25 13:29 ` Bruce Richardson
2016-02-26 0:46 ` Lu, Wenzhuo
2016-02-24 14:26 ` Bruce Richardson
2016-02-25 1:35 ` Lu, Wenzhuo
2016-02-26 3:05 ` [dpdk-dev] [PATCH v3] ixgbe: support link speed auto-neg " Wenzhuo Lu
2016-03-08 17:34 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308173433.GB6324@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).