From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2FCCD292D for ; Tue, 8 Mar 2016 18:34:37 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 08 Mar 2016 09:34:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,557,1449561600"; d="scan'208";a="919517838" Received: from ipdaly-mobl3.ger.corp.intel.com ([10.252.0.87]) by fmsmga001.fm.intel.com with SMTP; 08 Mar 2016 09:34:34 -0800 Received: by (sSMTP sendmail emulation); Tue, 08 Mar 2016 17:34:34 +0025 Date: Tue, 8 Mar 2016 17:34:33 +0000 From: Bruce Richardson To: Wenzhuo Lu Message-ID: <20160308173433.GB6324@bricha3-MOBL3> References: <1450684592-13564-1-git-send-email-wenzhuo.lu@intel.com> <1456455930-16124-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456455930-16124-1-git-send-email-wenzhuo.lu@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] ixgbe: support link speed auto-neg on x550em_x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 17:34:37 -0000 On Fri, Feb 26, 2016 at 11:05:29AM +0800, Wenzhuo Lu wrote: > Normally the auto-negotiation is supported by FW. SW need not care about > that. But on x550em_x, FW doesn't support auto-neg. As the ports of x550em_x > are 10G, if we connect the port will a peer which is 1G, the link will always > be down. > We need support auto-neg by SW to avoid this link down issue. As we already > have the code to handle the link speed setting, what we need is a trigger. > When the advertised link speed changes, a PHY interruption will be triggered. > So, we should handle this interruption and call ixgbe_handle_lasi to set the > link speed correctly. > > Please be aware it's working when auto-neg is on. If the auto-neg of the peer > port is turned off and its speed is indicated manually, we should also set > the speed of our own port manually. > > V2: > *Fix the wrong signoff name. > > V3: > *Change the tittle and add the explanation of the implementation in commit log. > > Signed-off-by: Wenzhuo Lu > Acked-by: Shaopeng He > --- Applied to dpdk-next-net/rel_16_04 /Bruce