Re: [dpdk-dev] [PATCH v5 0/4] DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Mar 09, 2016 at 12:34:51PM +0100, Jan Mędala wrote:
> I'd like to kindly request for review and comments.
> 
>  Jan

Hi Jan,

I've run checkpatch on these patches and below is some of the output that you
might want to look at fixing. As well as these, there were a *lot* of warnings
about lines over 80 characters, and indeed over 90 characters (since we allow
a little bit of wiggle-room in line length, I checked with 90 too).

Regards,
/Bruce

Patch 1:
--------
ERROR:TRAILING_WHITESPACE: trailing whitespace
#200: FILE: doc/guides/nics/ena.rst:165:
+Any Linux distribution fulfilling the conditions described in ``System Requirements`` $

Patch 2:
--------
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#83: FILE: drivers/net/ena/base/ena_com.c:68:
+static int ena_alloc_cnt = 0;

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#493: FILE: drivers/net/ena/base/ena_com.c:478:
+               if ((syst = ENA_GET_SYSTEM_USECS()) > timeout) {

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1818: FILE: drivers/net/ena/base/ena_com.c:1803:
+{
+

CHECK:LINE_SPACING: Please don't use multiple blank lines
#5574: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs_custom.h:39:
+
+

ERROR:C99_COMMENTS: do not use C99 // comments
#5575: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs_custom.h:40:
+#endif //_ENA_ADMIN_QUEUE_CUSTOM_H_

Patch 3:
--------
WARNING:NEW_TYPEDEFS: do not add new typedefs
#67: FILE: drivers/net/ena/base/ena_plat_dpdk.h:50:
+typedef rte_atomic32_t ena_atomic32_t;

WARNING:NEW_TYPEDEFS: do not add new typedefs
#75: FILE: drivers/net/ena/base/ena_plat_dpdk.h:58:
+typedef void *ena_mem_handle_t;

WARNING:NEW_TYPEDEFS: do not add new typedefs
#150: FILE: drivers/net/ena/base/ena_plat_dpdk.h:133:
+typedef struct {

Patch 4:
--------
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1727: FILE: drivers/net/ena/ena_platform.h:49:
+#define ena_assert_msg(cond, msg) ^I^I\$