From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4896A2C65 for ; Thu, 10 Mar 2016 13:00:20 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 10 Mar 2016 04:00:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,315,1455004800"; d="scan'208";a="761591806" Received: from ugavish-mobl1.ger.corp.intel.com ([10.252.20.226]) by orsmga003.jf.intel.com with SMTP; 10 Mar 2016 04:00:02 -0800 Received: by (sSMTP sendmail emulation); Thu, 10 Mar 2016 12:00:01 +0025 Date: Thu, 10 Mar 2016 12:00:01 +0000 From: Bruce Richardson To: Jan =?utf-8?Q?M=C4=99dala?= Message-ID: <20160310120000.GF14712@bricha3-MOBL3> References: <1457381110-20382-1-git-send-email-jan@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, Alexander Matushevsky Subject: Re: [dpdk-dev] [PATCH v5 0/4] DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 12:00:20 -0000 On Wed, Mar 09, 2016 at 12:34:51PM +0100, Jan Mędala wrote: > I'd like to kindly request for review and comments. > > Jan Hi Jan, I've run checkpatch on these patches and below is some of the output that you might want to look at fixing. As well as these, there were a *lot* of warnings about lines over 80 characters, and indeed over 90 characters (since we allow a little bit of wiggle-room in line length, I checked with 90 too). Regards, /Bruce Patch 1: -------- ERROR:TRAILING_WHITESPACE: trailing whitespace #200: FILE: doc/guides/nics/ena.rst:165: +Any Linux distribution fulfilling the conditions described in ``System Requirements`` $ Patch 2: -------- ERROR:INITIALISED_STATIC: do not initialise statics to 0 #83: FILE: drivers/net/ena/base/ena_com.c:68: +static int ena_alloc_cnt = 0; ERROR:ASSIGN_IN_IF: do not use assignment in if condition #493: FILE: drivers/net/ena/base/ena_com.c:478: + if ((syst = ENA_GET_SYSTEM_USECS()) > timeout) { CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1818: FILE: drivers/net/ena/base/ena_com.c:1803: +{ + CHECK:LINE_SPACING: Please don't use multiple blank lines #5574: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs_custom.h:39: + + ERROR:C99_COMMENTS: do not use C99 // comments #5575: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs_custom.h:40: +#endif //_ENA_ADMIN_QUEUE_CUSTOM_H_ Patch 3: -------- WARNING:NEW_TYPEDEFS: do not add new typedefs #67: FILE: drivers/net/ena/base/ena_plat_dpdk.h:50: +typedef rte_atomic32_t ena_atomic32_t; WARNING:NEW_TYPEDEFS: do not add new typedefs #75: FILE: drivers/net/ena/base/ena_plat_dpdk.h:58: +typedef void *ena_mem_handle_t; WARNING:NEW_TYPEDEFS: do not add new typedefs #150: FILE: drivers/net/ena/base/ena_plat_dpdk.h:133: +typedef struct { Patch 4: -------- WARNING:SPACE_BEFORE_TAB: please, no space before tabs #1727: FILE: drivers/net/ena/ena_platform.h:49: +#define ena_assert_msg(cond, msg) ^I^I\$