From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id A6DCF3239
 for <dev@dpdk.org>; Thu, 10 Mar 2016 17:32:44 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga103.jf.intel.com with ESMTP; 10 Mar 2016 08:32:21 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; d="scan'208";a="761735151"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.166])
 by orsmga003.jf.intel.com with SMTP; 10 Mar 2016 08:32:18 -0800
Received: by  (sSMTP sendmail emulation); Thu, 10 Mar 2016 16:32:17 +0025
Date: Thu, 10 Mar 2016 16:32:17 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Wang Xiao W <xiao.w.wang@intel.com>
Message-ID: <20160310163216.GJ18264@bricha3-MOBL3>
References: <1456810601-7419-2-git-send-email-xiao.w.wang@intel.com>
 <1456917554-30257-1-git-send-email-xiao.w.wang@intel.com>
 <1456917554-30257-2-git-send-email-xiao.w.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1456917554-30257-2-git-send-email-xiao.w.wang@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/2] fm10k: enable FTAG based forwarding
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 16:32:45 -0000

On Wed, Mar 02, 2016 at 07:19:13PM +0800, Wang Xiao W wrote:
> This patch enables reading sglort info into mbuf for RX and inserting
> an FTAG at the beginning of the packet for TX. The vlan_tci_outer field
> selected from rte_mbuf structure for sglort is not used in fm10k now.
> In FTAG based forwarding mode, the switch will forward packets according
> to glort info in FTAG rather than mac and vlan table.
> 
> To activate this feature, user needs to pass a devargs parameter to eal
> for fm10k device like "-w 0000:84:00.0,enable_ftag=1". Currently this
> feature is supported only on PF, because FM10K_PFVTCTL register is
> read-only for VF.
> 
> Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
> Acked-by: Jing Chen <jing.d.chen@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>

Not sure the acks are correctly recorded here. John has acked the documentation
patch (2/2), not this patch. I'll fix this on apply.
Next time, please try to record the acks more accurately.

Thanks,
/Bruce