* [dpdk-dev] [PATCH] enic: fix dma addr of outgoing packets
@ 2016-02-24 23:06 Yoann Desmouceaux
2016-03-10 21:32 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Yoann Desmouceaux @ 2016-02-24 23:06 UTC (permalink / raw)
To: johndale; +Cc: dev
The enic PMD driver send function uses a constant offset instead
of relying on the data_off in the mbuf to find the start of the packet.
Signed-off-by: Yoann Desmouceaux <ydesmouc@cisco.com>
---
drivers/net/enic/enic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 07a9810..f818c32 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -166,7 +166,7 @@ void enic_send_pkt(struct enic *enic, struct vnic_wq *wq,
uint16_t mss = 0;
uint8_t vlan_tag_insert = 0;
uint64_t bus_addr = (dma_addr_t)
- (tx_pkt->buf_physaddr + RTE_PKTMBUF_HEADROOM);
+ (tx_pkt->buf_physaddr + tx_pkt->data_off);
if (sop) {
if (ol_flags & PKT_TX_VLAN_PKT)
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] enic: fix dma addr of outgoing packets
2016-02-24 23:06 [dpdk-dev] [PATCH] enic: fix dma addr of outgoing packets Yoann Desmouceaux
@ 2016-03-10 21:32 ` Bruce Richardson
2016-03-10 21:35 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2016-03-10 21:32 UTC (permalink / raw)
To: Yoann Desmouceaux; +Cc: dev, johndale
On Thu, Feb 25, 2016 at 12:06:15AM +0100, Yoann Desmouceaux wrote:
> The enic PMD driver send function uses a constant offset instead
> of relying on the data_off in the mbuf to find the start of the packet.
>
> Signed-off-by: Yoann Desmouceaux <ydesmouc@cisco.com>
> ---
> drivers/net/enic/enic_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
> index 07a9810..f818c32 100644
> --- a/drivers/net/enic/enic_main.c
> +++ b/drivers/net/enic/enic_main.c
> @@ -166,7 +166,7 @@ void enic_send_pkt(struct enic *enic, struct vnic_wq *wq,
> uint16_t mss = 0;
> uint8_t vlan_tag_insert = 0;
> uint64_t bus_addr = (dma_addr_t)
> - (tx_pkt->buf_physaddr + RTE_PKTMBUF_HEADROOM);
> + (tx_pkt->buf_physaddr + tx_pkt->data_off);
>
> if (sop) {
> if (ol_flags & PKT_TX_VLAN_PKT)
> --
> 2.1.4
>
Fixes: fefed3d1e62c ("enic: new driver")
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] enic: fix dma addr of outgoing packets
2016-03-10 21:32 ` Bruce Richardson
@ 2016-03-10 21:35 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-03-10 21:35 UTC (permalink / raw)
To: Yoann Desmouceaux; +Cc: dev, johndale
On Thu, Mar 10, 2016 at 09:32:58PM +0000, Bruce Richardson wrote:
> On Thu, Feb 25, 2016 at 12:06:15AM +0100, Yoann Desmouceaux wrote:
> > The enic PMD driver send function uses a constant offset instead
> > of relying on the data_off in the mbuf to find the start of the packet.
> >
> > Signed-off-by: Yoann Desmouceaux <ydesmouc@cisco.com>
> > ---
> > drivers/net/enic/enic_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
> > index 07a9810..f818c32 100644
> > --- a/drivers/net/enic/enic_main.c
> > +++ b/drivers/net/enic/enic_main.c
> > @@ -166,7 +166,7 @@ void enic_send_pkt(struct enic *enic, struct vnic_wq *wq,
> > uint16_t mss = 0;
> > uint8_t vlan_tag_insert = 0;
> > uint64_t bus_addr = (dma_addr_t)
> > - (tx_pkt->buf_physaddr + RTE_PKTMBUF_HEADROOM);
> > + (tx_pkt->buf_physaddr + tx_pkt->data_off);
> >
> > if (sop) {
> > if (ol_flags & PKT_TX_VLAN_PKT)
> > --
> > 2.1.4
> >
> Fixes: fefed3d1e62c ("enic: new driver")
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Applied to dpdk-next-net/rel_16_04
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-10 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-24 23:06 [dpdk-dev] [PATCH] enic: fix dma addr of outgoing packets Yoann Desmouceaux
2016-03-10 21:32 ` Bruce Richardson
2016-03-10 21:35 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).