From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id E2A772BF1 for ; Fri, 11 Mar 2016 22:47:21 +0100 (CET) Received: by mail-pa0-f51.google.com with SMTP id fe3so92904738pab.1 for ; Fri, 11 Mar 2016 13:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q772Nvj2ORecmabQZfhNsn8ODbjgNjZJRhnl7LPzFdg=; b=Do1qL1iSXrHu4p7sAv5d1o7k6ZD7lakEDuXsIZm8rz1oVgKgY8lPfCq6TzFi2Z5kdC 7FolvwX3jQrF5X6Q08NupBvDL3Gt+Q1UeubhJ8078Y9Jxd7+snp8bpxl95YIQAMzjvne sC5syLC3xi3/j7cE+j/eQhL+VM+ZmViPnpeutyxIc+fhl5sszcI53+1gcgr2Bj6vgwLI /j42A3CsUpsx8p6EVX6H5jB0gz8MpB/T3QHFSxVzIQRpnKbLJ/xMkFVfT1Vw7uUl8D8I I5tByFvjEMfZk4odvucXRHyqTWug2zXpGNh8S0Zd7UG0XUVhEOrPekPNGkGhV98Lu6Qg 86rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q772Nvj2ORecmabQZfhNsn8ODbjgNjZJRhnl7LPzFdg=; b=VOSZ9imib410ozYMl/WRWEhCPxfYRphQVQYdVsWR4xUZINkmn9Oekop9LJCSynhB43 +Af+20fs00aqqWaLSL2/jio0heOOjYUmnPqwGC3fWMtm0eZ/Qo6Knsqm/x/GX7d8AdoB h4XYWY+XNjskyxYEdx7QpyIAAwpktjl7+4CcogoaTyfG3slhCrzY+T4P6atTsUZsK70m t42j9eFTKIWsl8hW9CkA+/p0OwITyNFyndEXgLfpBCgT3fEn1Jyj4rt5gzrPHnwd2O3A zSKYkU6oCxLwh7ubnPYGXDUoSJqnCiHzcj7WQ7syGwlFkybJ+kgegAg3QaBM9w3G50Ej PSLA== X-Gm-Message-State: AD7BkJIfcO7KvmFT6P3n6uirauB1sXQdBjrTD7j5sOqnRXbid21bWEVEZk3y0fgumGdRvw== X-Received: by 10.66.90.136 with SMTP id bw8mr19261890pab.52.1457732841222; Fri, 11 Mar 2016 13:47:21 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id e1sm15139173pas.1.2016.03.11.13.47.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Mar 2016 13:47:20 -0800 (PST) Date: Fri, 11 Mar 2016 13:47:33 -0800 From: Stephen Hemminger To: Olivier MATZ Message-ID: <20160311134733.7b931eec@xeon-e3> In-Reply-To: <56E12C48.3070107@6wind.com> References: <1457540381-20274-1-git-send-email-olivier.matz@6wind.com> <1457540381-20274-11-git-send-email-olivier.matz@6wind.com> <56E08BE7.6030906@6wind.com> <20160309130159.309e5606@xeon-e3> <56E12C48.3070107@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC 10/35] eal: introduce RTE_DECONST macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 21:47:22 -0000 On Thu, 10 Mar 2016 09:11:52 +0100 Olivier MATZ wrote: > > > I would rather have the mempool_audit code take a non-const argument. > > The macro method sets a bad precedent and will encourage more bad code. > > Plus code checkers are likely to flag any such usage as suspect. > > Doing that would imply dropping the const qualifier in several > functions: > > - rte_mempool_dump() > - rte_mempool_audit() > - mempool_audit_cookies() > - mempool_audit_cache() Sure no problem.