DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, "Cornu, Marcel D" <marcel.d.cornu@intel.com>,
	"Kantecki, Tomasz" <tomasz.kantecki@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP, example of libpqos usage
Date: Fri, 11 Mar 2016 16:27:06 +0000	[thread overview]
Message-ID: <20160311162706.GD19860@bricha3-MOBL3> (raw)
In-Reply-To: <2637627.HOJADSlSRT@xps13>

On Fri, Mar 11, 2016 at 05:03:23PM +0100, Thomas Monjalon wrote:
> 2016-03-11 15:54, Kantecki, Tomasz:
> > > > +Basic Forwarding sample application is a simple *skeleton* example of
> > > > +a forwarding application. It has been extended to make use of CAT via
> > > > +extended command line options and linking against the libpqos library.
> > > 
> > > The skeleton aims to show a minimal piece of code (but bigger than hello
> > > world).
> > > For any other usage, I think the "l2fwd" name is more appropriate.
> > > 
> > > > +DIRS-y += skeleton-cat
> > > 
> > 
> > We have used skeleton app as basis for this sample code. It is just to keep it as simple as possible.
> > Wouldn't it be confusing if we use "l2fwd" name for skeleton app functionality?
> 
> I'm not sure.
> We need more opinions.

Skeleton app does do a form of l2 forwarding, just without editing the mac addresses.
I don't think having "skeleton" in the name of derived apps is a good thing, so
I would vote for an l2fwd-based name.

/Bruce

  reply	other threads:[~2016-03-11 16:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 13:26 [dpdk-dev] [PATCH] " Wojciech Andralojc
2016-02-26 15:07 ` [dpdk-dev] [PATCH v2] " Wojciech Andralojc
2016-03-07 14:34   ` Van Haaren, Harry
2016-03-07 16:54   ` [dpdk-dev] [PATCH v3] " Wojciech Andralojc
2016-03-07 17:19     ` Van Haaren, Harry
2016-03-11 13:50     ` Thomas Monjalon
2016-03-11 15:54       ` Kantecki, Tomasz
2016-03-11 16:03         ` Thomas Monjalon
2016-03-11 16:27           ` Bruce Richardson [this message]
2016-03-11 16:34             ` Kantecki, Tomasz
2016-03-11 16:38               ` Thomas Monjalon
2016-03-11 16:24   ` [dpdk-dev] [PATCH v4] " Wojciech Andralojc
2016-03-14 13:46   ` [dpdk-dev] [PATCH v5] examples/l2fwd-cat: " Wojciech Andralojc
2016-03-21 22:35     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311162706.GD19860@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=marcel.d.cornu@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=tomasz.kantecki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).