From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 96B4029C7
 for <dev@dpdk.org>; Fri, 11 Mar 2016 17:27:10 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 11 Mar 2016 08:27:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,321,1455004800"; d="scan'208";a="934786235"
Received: from cberenge-mobl.ger.corp.intel.com ([10.252.22.153])
 by fmsmga002.fm.intel.com with SMTP; 11 Mar 2016 08:27:07 -0800
Received: by  (sSMTP sendmail emulation); Fri, 11 Mar 2016 16:27:07 +0025
Date: Fri, 11 Mar 2016 16:27:06 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160311162706.GD19860@bricha3-MOBL3>
References: <1456499233-66251-1-git-send-email-wojciechx.andralojc@intel.com>
 <2207879.MgxKVmgPIQ@xps13>
 <E79CF84CF47B0B42B66F4F5835125F9C817C5E0D@IRSMSX101.ger.corp.intel.com>
 <2637627.HOJADSlSRT@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2637627.HOJADSlSRT@xps13>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org, "Cornu, Marcel D" <marcel.d.cornu@intel.com>, "Kantecki,
 Tomasz" <tomasz.kantecki@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP,
 example of libpqos usage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2016 16:27:11 -0000

On Fri, Mar 11, 2016 at 05:03:23PM +0100, Thomas Monjalon wrote:
> 2016-03-11 15:54, Kantecki, Tomasz:
> > > > +Basic Forwarding sample application is a simple *skeleton* example of
> > > > +a forwarding application. It has been extended to make use of CAT via
> > > > +extended command line options and linking against the libpqos library.
> > > 
> > > The skeleton aims to show a minimal piece of code (but bigger than hello
> > > world).
> > > For any other usage, I think the "l2fwd" name is more appropriate.
> > > 
> > > > +DIRS-y += skeleton-cat
> > > 
> > 
> > We have used skeleton app as basis for this sample code. It is just to keep it as simple as possible.
> > Wouldn't it be confusing if we use "l2fwd" name for skeleton app functionality?
> 
> I'm not sure.
> We need more opinions.

Skeleton app does do a form of l2 forwarding, just without editing the mac addresses.
I don't think having "skeleton" in the name of derived apps is a good thing, so
I would vote for an l2fwd-based name.

/Bruce