From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B30A42BEA for ; Fri, 11 Mar 2016 17:40:20 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 11 Mar 2016 08:40:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,321,1455004800"; d="scan'208";a="934794485" Received: from cberenge-mobl.ger.corp.intel.com ([10.252.22.153]) by fmsmga002.fm.intel.com with SMTP; 11 Mar 2016 08:40:17 -0800 Received: by (sSMTP sendmail emulation); Fri, 11 Mar 2016 16:40:17 +0025 Date: Fri, 11 Mar 2016 16:40:17 +0000 From: Bruce Richardson To: Ferruh Yigit Message-ID: <20160311164016.GE19860@bricha3-MOBL3> References: <1456229580-25009-1-git-send-email-bernard.iremonger@intel.com> <1457350840-29426-1-git-send-email-bernard.iremonger@intel.com> <56DD70BB.8060909@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56DD70BB.8060909@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] bonding: fix crash when no slave devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2016 16:40:21 -0000 On Mon, Mar 07, 2016 at 12:14:51PM +0000, Ferruh Yigit wrote: > On 3/7/2016 11:40 AM, Bernard Iremonger wrote: > > If a bonded device is created when there are no slave devices > > there is loop in bond_ethdev_promiscous_enable() which results > > in a segmentation fault. > > > > The solution is to initialise the current_primary_port to an > > invalid port value when the bonded port is created. > > > > Fixes: 2efb58cbab6e ("bond: new link bonding library") > > Signed-off-by: Bernard Iremonger > > Acked-by: Ferruh Yigit Applied to dpdk-next-net/rel_16_04 /Bruce