From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 63D3139EA
 for <dev@dpdk.org>; Mon, 14 Mar 2016 13:21:48 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 14 Mar 2016 05:21:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,335,1455004800"; d="scan'208";a="909852566"
Received: from unknown ([10.252.25.185])
 by orsmga001.jf.intel.com with SMTP; 14 Mar 2016 05:21:45 -0700
Received: by  (sSMTP sendmail emulation); Mon, 14 Mar 2016 12:21:44 +0025
Date: Mon, 14 Mar 2016 12:21:44 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: dev@dpdk.org, helin.zhang@intel.com, zhe.tao@intel.com
Message-ID: <20160314122144.GB25348@bricha3-MOBL3>
References: <1457503249-14878-1-git-send-email-jingjing.wu@intel.com>
 <1457581271-22871-1-git-send-email-jingjing.wu@intel.com>
 <1457581271-22871-2-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1457581271-22871-2-git-send-email-jingjing.wu@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v5 1/2] i40evf: allocate virtchnl cmd buffer
	for each vf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Mar 2016 12:21:48 -0000

On Thu, Mar 10, 2016 at 11:41:10AM +0800, Jingjing Wu wrote:
> Currently, i40evf PMD uses a global static buffer to send virtchnl
> command to host driver. It is shared by multi VFs.
> This patch changed to allocate virtchnl cmd buffer for each VF.
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.h    |   2 +
>  drivers/net/i40e/i40e_ethdev_vf.c | 178 +++++++++++++++-----------------------
>  2 files changed, 71 insertions(+), 109 deletions(-)
> 
Hi Jingjing,

I get some compilation errors when I apply this to dpdk-next-net.

/home/bruce/next-net/dpdk-next-net/drivers/net/i40e/i40e_ethdev_vf.c: In function ‘i40evf_add_del_all_mac_addr’:
/home/bruce/next-net/dpdk-next-net/drivers/net/i40e/i40e_ethdev_vf.c:1801:21: error: ‘cmd_result_buffer’ undeclared (first use in this function)
   args.out_buffer = cmd_result_buffer;
                        ^

This is with Fedora 23 with gcc 5.3.1

/Bruce