From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1B4484AC7 for ; Mon, 14 Mar 2016 13:43:51 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 14 Mar 2016 05:43:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,335,1455004800"; d="scan'208";a="763762983" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga003.jf.intel.com with ESMTP; 14 Mar 2016 05:43:49 -0700 Date: Mon, 14 Mar 2016 20:44:32 +0800 From: Yuanhan Liu To: Bruce Richardson , Thomas Monjalon Cc: David Marchand , "dev@dpdk.org" Message-ID: <20160314124432.GP979@yliu-dev.sh.intel.com> References: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com> <20160310075054.GH979@yliu-dev.sh.intel.com> <20160314104830.GC24288@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160314104830.GC24288@bricha3-MOBL3> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2016 12:43:52 -0000 On Mon, Mar 14, 2016 at 10:48:31AM +0000, Bruce Richardson wrote: > On Thu, Mar 10, 2016 at 03:50:54PM +0800, Yuanhan Liu wrote: > > On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote: > > > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu > > > wrote: > > > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > > > > a random upper 32 bit feature bits, as the following io port read reads > > > > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1 > > > > (the 32th bit) for legacy virtio, which is obviously wrong. > > > > > > > > Fixes: b8f04520ad71 ("virtio: use PCI ioport API") > > > > > > > > Cc: David Marchand > > > > Signed-off-by: Yuanhan Liu > > > > > > Argh, good catch. > > > Relooked at my patch, this should be the only bug (of this kind ;-)). > > > > Yes, I also have a check while making this patch. > > > > --yliu > > > > > > Reviewed-by: David Marchand > > > > > > > > > -- > > > David Marchand > Hi, > > this patch no longer applies to dpdk-next-net/rel_16_04 branch due to changes > in legacy_get_features function. Hi Bruce, It's a patch based on Thomas' tree. And this patch fixes an regression at there, too. --yliu > Is it still needed? If so, please do a V2. > > Regards, > /Bruce