From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 2DEB22C5E
for <dev@dpdk.org>; Mon, 14 Mar 2016 14:55:21 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga103.fm.intel.com with ESMTP; 14 Mar 2016 06:54:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,335,1455004800"; d="scan'208";a="669274012"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.49])
by FMSMGA003.fm.intel.com with SMTP; 14 Mar 2016 06:54:56 -0700
Received: by (sSMTP sendmail emulation); Mon, 14 Mar 2016 13:54:55 +0025
Date: Mon, 14 Mar 2016 13:54:55 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20160314135455.GA24168@bricha3-MOBL3>
References: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com>
<CALwxeUvJwDUNmparc3hT=8SJz1r36LZm6Z9_fFD_rFssuD7nnA@mail.gmail.com>
<20160310075054.GH979@yliu-dev.sh.intel.com>
<20160314104830.GC24288@bricha3-MOBL3>
<20160314124432.GP979@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160314124432.GP979@yliu-dev.sh.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong features returned for
legacy virtio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Mar 2016 13:55:22 -0000
On Mon, Mar 14, 2016 at 08:44:32PM +0800, Yuanhan Liu wrote:
> On Mon, Mar 14, 2016 at 10:48:31AM +0000, Bruce Richardson wrote:
> > On Thu, Mar 10, 2016 at 03:50:54PM +0800, Yuanhan Liu wrote:
> > > On Thu, Mar 10, 2016 at 08:43:37AM +0100, David Marchand wrote:
> > > > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu
> > > > <yuanhan.liu@linux.intel.com> wrote:
> > > > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get
> > > > > a random upper 32 bit feature bits, as the following io port read reads
> > > > > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1
> > > > > (the 32th bit) for legacy virtio, which is obviously wrong.
> > > > >
> > > > > Fixes: b8f04520ad71 ("virtio: use PCI ioport API")
> > > > >
> > > > > Cc: David Marchand <david.marchand@6wind.com>
> > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > > >
> > > > Argh, good catch.
> > > > Relooked at my patch, this should be the only bug (of this kind ;-)).
> > >
> > > Yes, I also have a check while making this patch.
> > >
> > > --yliu
> > > >
> > > > Reviewed-by: David Marchand <david.marchand@6wind.com>
> > > >
> > > >
> > > > --
> > > > David Marchand
> > Hi,
> >
> > this patch no longer applies to dpdk-next-net/rel_16_04 branch due to changes
> > in legacy_get_features function.
>
> Hi Bruce,
>
> It's a patch based on Thomas' tree. And this patch fixes an regression
> at there, too.
>
> --yliu
>
Ok, thanks for the info.
Thomas, I'm delegating this patch to you in patchwork to apply to your tree.
/Bruce