From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 32CB85594 for ; Wed, 16 Mar 2016 14:45:51 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l124so49339609wmf.1 for ; Wed, 16 Mar 2016 06:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=edl9K4YHqaL1bw95QlpL9WCkzxJfSpYsxObjyfQSEBY=; b=1VBP0cZ219O7b8LRYfwwCC7KgTTD2jojrG10iK/gexuUA/JEQcrI5l1toa9HplOgJQ ya/vfwAuJw1i+96msUosKvB3R7m9ah3nWTs+58fqozLwRmc000DSBp3t6Oj2Lv//4reg Tgh966cx4RHCE5k9litRtxDypA7pp5L8RWL/pXReWEJxjRkte5xJ6KddEtq6ZpNZ3X24 eItZFwqqaEPUUHkvj1KF83k5/28jAckCDgqqEeeyxkSFKDzPxqALQrtirlBosExy27X1 rbpMpZVnFV8P2cSuwv43/JrQ4239XGxnDHxsNpLCfQHqbSjjwZrIY0NNnUgks1jnnBhW axSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=edl9K4YHqaL1bw95QlpL9WCkzxJfSpYsxObjyfQSEBY=; b=P8w2o2nhAHw2fYc7rsFVFPRJJgyZcthJ/KYMnd13zpXNBWw8LqiRtfFANeXJsfpBLi 8eqgM+tq1CYM66i9zXfR33qllxxoFbPQOgcgQg+kFn7J3AoAojtT/b09opZoHKVMmJZV z+qcxPYGt9KNlTdJkbqsLFUmIAEb17dfFIlSeZKzsa85gZpEBiF9S72OvVq/H5bVzbQ7 TQ5EDA0fD43FA74XDTUJF+JF6eGaRkRvA8UK7Bwtsd7+JVmVCvh29jKwpRbYdthboVBK rD/NU5YOU4fai2lyCeDk9RCD/7jAsAtHH7uHzyo0h7QHLUyyE7YHuOxzbyTIHks5DWgu x7LQ== X-Gm-Message-State: AD7BkJKJ32yhgot8PmaC9Qwfw6o8foanQQeo+0FiAXLpswuWGfXwvr3BkfRS+ejYQH2IvmMw X-Received: by 10.28.139.147 with SMTP id n141mr30778666wmd.53.1458135951025; Wed, 16 Mar 2016 06:45:51 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id l135sm3605566wmb.13.2016.03.16.06.45.49 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Mar 2016 06:45:50 -0700 (PDT) Date: Wed, 16 Mar 2016 14:45:36 +0100 From: Adrien Mazarguil To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20160316134536.GE27079@6wind.com> Mail-Followup-To: Bruce Richardson , dev@dpdk.org References: <1456165148-28416-1-git-send-email-adrien.mazarguil@6wind.com> <1457015279-3089-1-git-send-email-adrien.mazarguil@6wind.com> <1457015279-3089-6-git-send-email-adrien.mazarguil@6wind.com> <20160311152443.GA12500@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160311152443.GA12500@bricha3-MOBL3> Subject: Re: [dpdk-dev] [PATCH v2 5/5] mlx5: add VLAN insertion offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 13:45:51 -0000 On Fri, Mar 11, 2016 at 03:24:43PM +0000, Bruce Richardson wrote: > On Thu, Mar 03, 2016 at 03:27:59PM +0100, Adrien Mazarguil wrote: > > From: Yaacov Hazan > > > > VLAN insertion is done in software by the PMD by default unless > > CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION is enabled and Verbs provides > > support for hardware insertion. > > > > When enabled, this option improves performance when VLAN insertion is > > requested, however ConnectX-4 Lx boards cannot take advantage of > > multi-packet send optimizations anymore. > > > > Signed-off-by: Yaacov Hazan > > Signed-off-by: Adrien Mazarguil > > --- > > config/common_linuxapp | 1 + > > doc/guides/nics/mlx5.rst | 9 +++ > > doc/guides/rel_notes/release_16_04.rst | 6 ++ > > drivers/net/mlx5/Makefile | 9 +++ > > drivers/net/mlx5/mlx5_defs.h | 9 +++ > > drivers/net/mlx5/mlx5_ethdev.c | 12 ++-- > > drivers/net/mlx5/mlx5_rxtx.c | 109 +++++++++++++++++++++++++++------ > > drivers/net/mlx5/mlx5_rxtx.h | 13 ++++ > > drivers/net/mlx5/mlx5_txq.c | 15 ++++- > > 9 files changed, 158 insertions(+), 25 deletions(-) > > > > diff --git a/config/common_linuxapp b/config/common_linuxapp > > index 7b5e49f..793d262 100644 > > --- a/config/common_linuxapp > > +++ b/config/common_linuxapp > > @@ -220,6 +220,7 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=n > > CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N=4 > > CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE=0 > > CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8 > > +CONFIG_RTE_LIBRTE_MLX5_VERBS_VLAN_INSERTION=n > > > New build time configuration options are no longer allowed in DPDK, as they can't > be used in binary distributions and make testing harder. This should be made > a run-time option instead. OK, it was done as a performance improvement for a specific case, I will submit an updated patchset without this option. -- Adrien Mazarguil 6WIND