From: Matthew Hall <mhall@mhcomputing.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal_interrupts.c: properly init struct epoll_event (valgrind)
Date: Thu, 17 Mar 2016 16:00:55 -0700 [thread overview]
Message-ID: <20160317230055.GB10279@mhcomputing.net> (raw)
In-Reply-To: <20160317101924.16f7bf45@samsung9>
On Thu, Mar 17, 2016 at 10:19:24AM -0700, Stephen Hemminger wrote:
> > > A better patch would be to move the data structure into the
> > > code block used, and get rid of the useless else (rte_panic never returns);
> > > and fix the indentation, and use C99 initialization which should make valgrind
> > > happier.
> > >
> > > The moral is don't just slap memsets around
Hi guys,
As you probably read before, I am a security developer, not a low-level /
kernel guy, and my DPDK work is spare time only. So I try to limit the scope
of my DPDK patches where possible, to avoid making headaches for the full-time
team to the minimum required. I can try to redo or refactor all this unrelated
stuff in the code, but I wouldn't be as fast or accurate as you would.
Matthew.
prev parent reply other threads:[~2016-03-17 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 6:41 Matthew Hall
2016-02-14 20:22 ` Stephen Hemminger
2016-03-17 14:18 ` Thomas Monjalon
2016-03-17 17:19 ` Stephen Hemminger
2016-03-17 23:00 ` Matthew Hall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317230055.GB10279@mhcomputing.net \
--to=mhall@mhcomputing.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).