From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mhall@mhcomputing.net>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.228.170])
 by dpdk.org (Postfix) with ESMTP id 67D1E5323
 for <dev@dpdk.org>; Fri, 18 Mar 2016 00:00:56 +0100 (CET)
Received: by mail.mhcomputing.net (Postfix, from userid 1000)
 id F13CBC8; Thu, 17 Mar 2016 16:00:55 -0700 (PDT)
Date: Thu, 17 Mar 2016 16:00:55 -0700
From: Matthew Hall <mhall@mhcomputing.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Message-ID: <20160317230055.GB10279@mhcomputing.net>
References: <1455345678-17662-1-git-send-email-mhall@mhcomputing.net>
 <20160214122209.38b0efb6@xeon-e3> <1663421.MSGVGpLJHn@xps13>
 <20160317101924.16f7bf45@samsung9>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160317101924.16f7bf45@samsung9>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH] eal_interrupts.c: properly init struct
 epoll_event (valgrind)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Mar 2016 23:00:56 -0000

On Thu, Mar 17, 2016 at 10:19:24AM -0700, Stephen Hemminger wrote:
> > > A better patch would be to move the data structure into the
> > > code block used, and get rid of the useless else (rte_panic never returns);
> > > and fix the indentation, and use C99 initialization which should make valgrind
> > > happier.
> > > 
> > > The moral is don't just slap memsets around

Hi guys,

As you probably read before, I am a security developer, not a low-level / 
kernel guy, and my DPDK work is spare time only. So I try to limit the scope 
of my DPDK patches where possible, to avoid making headaches for the full-time 
team to the minimum required. I can try to redo or refactor all this unrelated 
stuff in the code, but I wouldn't be as fast or accurate as you would.

Matthew.