From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Ilya Maximets <i.maximets@samsung.com>,
Huawei Xie <huawei.xie@intel.com>,
bruce.richardson@intel.com, dev@dpdk.org,
Dyasly Sergey <s.dyasly@samsung.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Jianbo Liu <jianbo.liu@linaro.org>,
Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [dpdk-dev] [PATCH RFC v3 0/3] Thread safe rte_vhost_enqueue_burst().
Date: Fri, 18 Mar 2016 16:00:35 +0800 [thread overview]
Message-ID: <20160318080035.GS979@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <10269895.UfVQWhbqLk@xps13>
On Thu, Mar 17, 2016 at 04:29:32PM +0100, Thomas Monjalon wrote:
> 2016-02-24 14:47, Ilya Maximets:
> > Implementation of rte_vhost_enqueue_burst() based on lockless ring-buffer
> > algorithm and contains almost all to be thread-safe, but it's not.
> >
> > This set adds required changes.
> >
> > First patch in set is a standalone patch that fixes many times discussed
> > issue with barriers on different architectures.
> >
> > Second and third adds fixes to make rte_vhost_enqueue_burst thread safe.
>
> My understanding is that we do not want to pollute Rx/Tx with locks.
>
> Huawei, Yuanhan, Bruce, do you confirm?
Huawei would like to do that, and I'm behind that. Let's do it. The
question is can we do that in this release? As I replied in another
thread, I'm wondering we might need do an announce first and do it
in next release?
Both are Okay to me; I just want to know which one is more proper.
Thoughts?
--yliu
next prev parent reply other threads:[~2016-03-18 7:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 11:47 Ilya Maximets
2016-02-24 11:47 ` [dpdk-dev] [PATCH RFC v3 1/3] vhost: use SMP barriers instead of compiler ones Ilya Maximets
2016-03-18 10:08 ` Xie, Huawei
2016-03-18 10:23 ` Ilya Maximets
2016-03-18 10:27 ` Xie, Huawei
2016-03-18 10:39 ` Ilya Maximets
2016-03-18 10:47 ` Xie, Huawei
2016-03-18 11:00 ` Ilya Maximets
[not found] ` <C37D651A908B024F974696C65296B57B4C67825C@SHSMSX101.ccr.corp.intel.com>
[not found] ` <56EBE9AE.9070400@samsung.com>
[not found] ` <56EBF256.8040409@samsung.com>
2016-03-18 12:28 ` Ilya Maximets
2016-03-18 12:23 ` [dpdk-dev] [PATCH v4] " Ilya Maximets
2016-03-18 12:41 ` Yuanhan Liu
2016-03-21 4:49 ` Ilya Maximets
2016-03-21 14:07 ` Ananyev, Konstantin
2016-03-21 17:25 ` Xie, Huawei
2016-03-21 17:36 ` Ananyev, Konstantin
2016-03-23 14:07 ` Xie, Huawei
2016-03-31 13:46 ` Thomas Monjalon
2016-02-24 11:47 ` [dpdk-dev] [PATCH RFC v3 2/3] vhost: make buf vector for scatter RX local Ilya Maximets
2016-02-24 11:47 ` [dpdk-dev] [PATCH RFC v3 3/3] vhost: avoid reordering of used->idx and last_used_idx updating Ilya Maximets
2016-03-17 15:29 ` [dpdk-dev] [PATCH RFC v3 0/3] Thread safe rte_vhost_enqueue_burst() Thomas Monjalon
2016-03-18 8:00 ` Yuanhan Liu [this message]
2016-03-18 8:09 ` Thomas Monjalon
2016-03-18 9:16 ` Yuanhan Liu
2016-03-18 9:34 ` Thomas Monjalon
2016-03-18 9:46 ` Yuanhan Liu
2016-03-18 9:55 ` Ilya Maximets
2016-03-18 10:10 ` Xie, Huawei
2016-03-18 10:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318080035.GS979@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=i.maximets@samsung.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=mukawa@igel.co.jp \
--cc=s.dyasly@samsung.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).