From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id 05BA62C4D for ; Mon, 21 Mar 2016 18:32:30 +0100 (CET) Received: by mail-pf0-f175.google.com with SMTP id n5so272178536pfn.2 for ; Mon, 21 Mar 2016 10:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=igGIXqBzftrxUYm5R4dGmDjJkViMALi4hYrzvEd/Or4=; b=IXVL1/PnLGQZPIidQ7dkCgIw1ScMWGV75Rn9C8JTFKLOBoQ9FFx8qtXQosNP6wFMf5 rysO3jlVWimk2KgG72+X3qJ9OfnJ8/K3bTWapeQclci3ERF7/TSGMcDWn1gThpP7mP3w W9RO5KOyNFhBH+ABp0Ue1DpwfDHFa5uzxR0w1C4WUvyq7zElj/VBrjvJ0BdAWJzxrXIz pz8nfzsfT0VEq1S0RNBeOFaprAAB6XilSh5vrrP0kr7vSzQXeHAHVwuKzpr0KHwc0dKl i4Acqf7O9O2wwMnmHsdWN8wR5/2ip/7XxbyWfIo+ZlP0mzlZg8mb+2u8u9jPY85hTCCC q7eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=igGIXqBzftrxUYm5R4dGmDjJkViMALi4hYrzvEd/Or4=; b=AvUwjptzGag54mYZWcpkpaGPVR1sIbOm0w9s9g2JcZxswIpWBtkgw9i5dd7t+h3fu1 U+3ugoZFEBdQI0qE1Y0nHyWY4CDb/yaMjUFfN8AShDJvyHl04eg7EK30N6b+Kc6xV3In 58iYNEgTn2xaya4n+IJwYv44nYvku6X9wY9c0kPJ9wl6nMZH+wmonQtm+mhw32ueTVcY SzCGOOJZb5eUBFdnv9mcsHQOG1VTZ/MK23k9WKJhVfw2PxZ4ljg8TMz3j618N9Oq/opZ H8vZbuVV2XgGeiwXL8SUUTkNDHPAxUO/a2/X39/6l/TJJfeIogbNxxgQaJlsZlGTAS3o BXww== X-Gm-Message-State: AD7BkJKdlsi2CNXcgS9A3ESSmS2OMsqU/8FJI09ZQ4csBuOu2MbkPwWxKYU/UFCvkmyimg== X-Received: by 10.66.138.74 with SMTP id qo10mr46547418pab.140.1458581549390; Mon, 21 Mar 2016 10:32:29 -0700 (PDT) Received: from xeon-e3 (static-50-53-65-230.bvtn.or.frontiernet.net. [50.53.65.230]) by smtp.gmail.com with ESMTPSA id o71sm42096655pfj.68.2016.03.21.10.32.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Mar 2016 10:32:29 -0700 (PDT) Date: Mon, 21 Mar 2016 10:32:44 -0700 From: Stephen Hemminger To: Rasesh Mody Cc: , , , , , Message-ID: <20160321103244.4e158f5d@xeon-e3> In-Reply-To: <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com> References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com> <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 05/10] qede: Add core driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 17:32:30 -0000 On Fri, 18 Mar 2016 17:53:20 -0700 Rasesh Mody wrote: > +static struct eth_dev_ops qede_eth_dev_ops = { > + .dev_configure = qede_dev_configure, > + .dev_infos_get = qede_dev_info_get, > + .rx_queue_setup = qede_rx_queue_setup, > + .rx_queue_release = qede_rx_queue_release, > + .tx_queue_setup = qede_tx_queue_setup, > + .tx_queue_release = qede_tx_queue_release, > + .dev_start = qede_dev_start, > + .dev_set_link_up = qede_dev_set_link_up, > + .dev_set_link_down = qede_dev_set_link_down, > + .link_update = qede_link_update, > + .promiscuous_enable = qede_promiscuous_enable, > + .promiscuous_disable = qede_promiscuous_disable, > + .allmulticast_enable = qede_allmulticast_enable, > + .allmulticast_disable = qede_allmulticast_disable, > + .dev_stop = qede_dev_stop, > + .dev_close = qede_dev_close, > + .stats_get = qede_get_stats, > + .mac_addr_add = qede_mac_addr_add, > + .mac_addr_remove = qede_mac_addr_remove, > + .vlan_offload_set = qede_vlan_offload_set, > + .vlan_filter_set = qede_vlan_filter_set, > + .flow_ctrl_set = qede_flow_ctrl_set, > + .flow_ctrl_get = qede_flow_ctrl_get, > +}; > + All eth_dev_ops structures should be marked const. It makes it harder for attacker to find a handle.