From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com
 [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id 325732C05
 for <dev@dpdk.org>; Mon, 21 Mar 2016 18:44:53 +0100 (CET)
Received: by mail-pf0-f172.google.com with SMTP id x3so272682634pfb.1
 for <dev@dpdk.org>; Mon, 21 Mar 2016 10:44:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=xhB6qT3MnG6enHe0ME0OotKuOj9e65h3uTVu9dIO/TE=;
 b=GbCo/f6DiBpwyN4ftMesFAkEpt9sLTg2TSSaLUN4gzPzPqAjPDZEcpuTBboK4ZrGrA
 KQSmgC1PrS+FqPpw57MpyXKb3uSDO21FXOsHqGO4UPEsYKJIxL3is8zaAyot0NSv9gmv
 YmCMDmAhJ01Ya/pGMrstZaN3XOJJcq4bNjTo5fnAhxGjbe59HizTIZcokIavGbmH3Pxn
 LIQlr3hbEXIN6cjh6uvZVpBlP/UTo+M7WRwOeC3l61kJtTzjl7HeIQz5BLd+N/3byiIF
 AevJ+jUjCVLcpT0PuvzkP36udL5Dq3rJCYYNXjWoyhyhm/9JvuStL1cjScXAzSNo4Qhv
 Yzzg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=xhB6qT3MnG6enHe0ME0OotKuOj9e65h3uTVu9dIO/TE=;
 b=XLUgNEJQPp4CmYd8jg94Q83as1UfcJKg2litjSeJok3pT4T1orizWD31tp1XQQzKK6
 /RTzGYIggyoqv1rppB+tT5ug7gkPgE0gGQkj7RX+qFc9hjMnDOYoeJDSVGYvfkSxbVU0
 JOfMBLNGnGytsyiYTNBDe94DtmffoTywPRv8nzimir4JKI6ErEnEKoUUzC7qPOv9sZkj
 tjUuTVj9IewzyohetTSFJG3dVJOxi4UyaVRuNTW0M0zKzsaBt8bko1YGuSV97llTg8Ba
 j/LVT64i/Ivojvxb+gVcYOHi20fzqAUbnHpaZm15RD4+Q3xhB3of46cJ5BOa2q4RdwyN
 j49A==
X-Gm-Message-State: AD7BkJLLoi2/q6FOaCMujBlUd5hQHXU5iV9jKqPDGiD+EIjDoVE5DceQO7b4AL0nyxB27A==
X-Received: by 10.98.10.20 with SMTP id s20mr46738446pfi.109.1458582292591;
 Mon, 21 Mar 2016 10:44:52 -0700 (PDT)
Received: from xeon-e3 (static-50-53-65-230.bvtn.or.frontiernet.net.
 [50.53.65.230])
 by smtp.gmail.com with ESMTPSA id fa3sm42193331pab.45.2016.03.21.10.44.52
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 21 Mar 2016 10:44:52 -0700 (PDT)
Date: Mon, 21 Mar 2016 10:45:08 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Matej Vido <vido@cesnet.cz>
Cc: dev@dpdk.org
Message-ID: <20160321104508.2a318a69@xeon-e3>
In-Reply-To: <1434702301-4509-2-git-send-email-vido@cesnet.cz>
References: <1434702301-4509-1-git-send-email-vido@cesnet.cz>
 <1434702301-4509-2-git-send-email-vido@cesnet.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] szedata2: new poll mode driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Mar 2016 17:44:53 -0000

On Fri, 19 Jun 2015 10:25:00 +0200
Matej Vido <vido@cesnet.cz> wrote:

> +static struct ether_addr eth_addr = {
> +	.addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 }
> +};
...

> static int
> rte_szedata2_eth_dev_init(struct rte_eth_dev *dev)
> {
.. 
> 	/* Allocate space for one mac address */
> 	data->mac_addrs = rte_zmalloc(data->name, sizeof(struct ether_addr),
> 			RTE_CACHE_LINE_SIZE);
> 	if (data->mac_addrs == NULL) {
> 		RTE_LOG(ERR, PMD, "Could not alloc space for MAC address!\n");
> 		munmap(dev->pci_dev->mem_resource[PCI_RESOURCE_NUMBER].addr,
> 			dev->pci_dev->mem_resource[PCI_RESOURCE_NUMBER].len);
> 		return -EINVAL;
> 	}
> 
> 	ether_addr_copy(&eth_addr, data->mac_addrs);

If your hardware has no permanent MAC address, then please use eth_random_addr()
to make one on boot, rather than having a bogus static value.