DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
	"Liu, Yong" <yong.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
Date: Mon, 21 Mar 2016 14:57:33 +0000	[thread overview]
Message-ID: <20160321145732.GB16732@bricha3-MOBL3> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C8CCF84@IRSMSX108.ger.corp.intel.com>

On Mon, Mar 21, 2016 at 09:40:07AM +0000, De Lara Guarch, Pablo wrote:
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> > Monroy
> > Sent: Monday, March 21, 2016 9:13 AM
> > To: Liu, Yong; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
> > 
> > On 21/03/2016 01:44, Marvin Liu wrote:
> > > Build log:
> > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
> > > 's6_addr32' in 'struct in6_addr'
> > > 	rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
> > >
> > > This is caused by macro "s6_addr32" not defined on FreeBSD.
> > >
> > > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > >
> > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> > > index 9d52b8c..51ad23b 100644
> > > --- a/app/test-pmd/cmdline.c
> > > +++ b/app/test-pmd/cmdline.c
> > > @@ -6684,7 +6684,11 @@ cmd_tunnel_filter_parsed(void *parsed_result,
> > >   		int i;
> > >   		for (i = 0; i < 4; i++) {
> > >   			tunnel_filter_conf.ip_addr.ipv6_addr[i] =
> > > +#ifdef RTE_EXEC_ENV_BSDAPP
> > > +			rte_be_to_cpu_32(res-
> > >ip_value.addr.ipv6.__u6_addr.__u6_addr32[i]);
> > > +#else
> > >   			rte_be_to_cpu_32(res-
> > >ip_value.addr.ipv6.s6_addr32[i]);
> > > +#endif
> > 
> > Why not always use .__u6_addr.__u6_addr32[i] and avoid ifdef?
> > 
> > Sergio
> > 
> > >   		}
> > >   		tunnel_filter_conf.ip_type = RTE_TUNNEL_IPTYPE_IPV6;
> > >   	}
> 
> Also, can you include the missing "Fixes" line?
> 
A slightly higher level question:
Why are we doing 32-bit endian conversions, when IPv6 addresses are normally
specified in 16-bit (4-hex digit) blocks?

/Bruce

  reply	other threads:[~2016-03-21 14:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21  1:44 Marvin Liu
2016-03-21  8:59 ` Mrzyglod, DanielX T
2016-03-21  9:13 ` Sergio Gonzalez Monroy
2016-03-21  9:40   ` De Lara Guarch, Pablo
2016-03-21 14:57     ` Bruce Richardson [this message]
2016-03-22  3:30     ` Liu, Yong
2016-03-22  9:44       ` Sergio Gonzalez Monroy
2016-03-22  6:50 ` [dpdk-dev] [PATCH v2] " Marvin Liu
2016-03-22  9:05   ` Qiu, Michael
2016-03-23  9:20     ` Liu, Yong
2016-03-23  2:17   ` Wu, Jingjing
2016-03-23 15:17     ` Thomas Monjalon
2016-03-25 12:10       ` Bruce Richardson
2016-03-25 12:15         ` Bruce Richardson
2016-03-25 18:19           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321145732.GB16732@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).