* [dpdk-dev] [PATCH] git: ignore build directory
@ 2016-03-21 17:56 Stephen Hemminger
2016-03-21 20:57 ` Matthew Hall
2018-05-22 21:42 ` Thomas Monjalon
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2016-03-21 17:56 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
The mk environment in DPDK puts files in build/ directory
so it makes sense to have a .gitignore file to skip that
directory.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
.gitignore | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/.gitignore b/.gitignore
index e69de29..5dc652b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -0,0 +1,5 @@
+*.orig
+*.rej
+*~
+
+build
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] git: ignore build directory
2016-03-21 17:56 [dpdk-dev] [PATCH] git: ignore build directory Stephen Hemminger
@ 2016-03-21 20:57 ` Matthew Hall
2018-05-22 21:42 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Hall @ 2016-03-21 20:57 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Mon, Mar 21, 2016 at 10:56:18AM -0700, Stephen Hemminger wrote:
> The mk environment in DPDK puts files in build/ directory
> so it makes sense to have a .gitignore file to skip that
> directory.
The last time I proposed such a patch it was rejected. It is sad when
community patches are second class citizens behind core committers'
patches.
Matthew.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] git: ignore build directory
2016-03-21 17:56 [dpdk-dev] [PATCH] git: ignore build directory Stephen Hemminger
2016-03-21 20:57 ` Matthew Hall
@ 2018-05-22 21:42 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-05-22 21:42 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
21/03/2016 18:56, Stephen Hemminger:
> The mk environment in DPDK puts files in build/ directory
> so it makes sense to have a .gitignore file to skip that
> directory.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> .gitignore | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index e69de29..5dc652b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -0,0 +1,5 @@
> +*.orig
> +*.rej
> +*~
> +
> +build
Seems I never replied to this proposal.
I think .orig, .rej and other files should appear in git status.
About the "build" directory, yes it could be ignored.
But then we could ignore the default build directory and not other
build directories with specific names? Looks not consistent.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-22 21:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-21 17:56 [dpdk-dev] [PATCH] git: ignore build directory Stephen Hemminger
2016-03-21 20:57 ` Matthew Hall
2018-05-22 21:42 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).