From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 8BF972BD7
 for <dev@dpdk.org>; Tue, 22 Mar 2016 12:21:48 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 22 Mar 2016 04:21:47 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,376,1455004800"; d="scan'208";a="673742862"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.103])
 by FMSMGA003.fm.intel.com with SMTP; 22 Mar 2016 04:21:45 -0700
Received: by  (sSMTP sendmail emulation); Tue, 22 Mar 2016 11:21:44 +0025
Date: Tue, 22 Mar 2016 11:21:44 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
 harish.patil@qlogic.com, sony.chacko@qlogic.com
Message-ID: <20160322112144.GE19248@bricha3-MOBL3>
References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com>
 <1458348805-32648-11-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458348805-32648-11-git-send-email-rasesh.mody@qlogic.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3 10/10] qede: Enable PMD build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Mar 2016 11:21:49 -0000

On Fri, Mar 18, 2016 at 05:53:25PM -0700, Rasesh Mody wrote:
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---
>  config/common_base    |   14 ++++++++++++++
>  drivers/net/Makefile  |    1 +
>  mk/rte.app.mk         |    2 ++
>  scripts/test-build.sh |    1 +
>  4 files changed, 18 insertions(+)
> 
> diff --git a/config/common_base b/config/common_base
> index dbd405b..14b37df 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -295,6 +295,20 @@ CONFIG_RTE_LIBRTE_PMD_BOND=y
>  CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB=n
>  CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n
>  
> +# QLogic 25G/40G PMD
> +#
> +CONFIG_RTE_LIBRTE_QEDE_PMD=y
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_ECORE=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n
> +CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n
> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24
> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48
> +CONFIG_RTE_LIBRTE_QEDE_TX_SWITCHING=y
> +#Provides path/name of the firmware file
> +CONFIG_RTE_LIBRTE_QEDE_FW=n
> +
>  #
>  # Compile software PMD backed by AF_PACKET sockets (Linux only)
>  #
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 0c3393f..61d3f16 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -51,5 +51,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += szedata2
>  DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio
>  DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3
>  DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += xenvirt
> +DIRS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += qede

In general, lists in DPDK, including this list of subdirectories in the makefile
are kept in alphabetical order, rather than just having new items appended at the
end.

/Bruce

>  
>  include $(RTE_SDK)/mk/rte.subdir.mk
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index a1cd9a3..9bb2264 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD)       += -libverbs
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2)   += -lsze2
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT)    += -lxenstore
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD)      += -lgxio
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_QEDE_PMD)       += -lz
>  # QAT / AESNI GCM PMDs are dependent on libcrypto (from openssl)
>  # for calculating HMAC precomputes
>  ifeq ($(CONFIG_RTE_LIBRTE_PMD_QAT),y)
> @@ -146,6 +147,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD)      += -lrte_pmd_mpipe
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING)       += -lrte_pmd_ring
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP)       += -lrte_pmd_pcap
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += -lrte_pmd_af_packet
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_QEDE_PMD)       += -lrte_pmd_qede
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL)       += -lrte_pmd_null
>  
>  ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
> diff --git a/scripts/test-build.sh b/scripts/test-build.sh
> index 5f3cab5..dfc8915 100755
> --- a/scripts/test-build.sh
> +++ b/scripts/test-build.sh
> @@ -116,6 +116,7 @@ config () # <directory> <target> <options>
>  		test "$DPDK_DEP_ZLIB" != y || \
>  		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
>  		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
> +		sed -ri          's,(QEDE_PMD=)n,\1y,' $1/.config
>  		test "$DPDK_DEP_PCAP" != y || \
>  		sed -ri               's,(PCAP=)n,\1y,' $1/.config
>  		test -z "$AESNI_MULTI_BUFFER_LIB_PATH" || \
> -- 
> 1.7.10.3
>